2007-02-10 02:14:57

by Brian Behlendorf

[permalink] [raw]
Subject: e2fsprogs coverity patch <cid-47.diff>

Lawrence Livermore National Labs recently ran the source code
analysis tool Coverity over the e2fsprogs-1.39 source to see
if it would identify any significant bugs. The analysis
turned up 38 mostly minor issues which are enumerated here
with patches. We went through and resolved these issues
but would love to see these mostly minor changes reviewed
and commited upstream.

Brian Behlendorf <[email protected]>, and
Herb Wartens <[email protected]>

Coverity ID: 47: Used before assigned

long_opt must be initialized to 0 to ensure the 'l' option has the
desired effect.

Index: e2fsprogs+chaos/debugfs/htree.c
--- e2fsprogs+chaos.orig/debugfs/htree.c
+++ e2fsprogs+chaos/debugfs/htree.c
@@ -181,7 +181,7 @@ void do_htree_dump(int argc, char *argv[
ext2_ino_t ino;
struct ext2_inode inode;
int c;
- int long_opt;
+ int long_opt = 0;
char *buf = NULL;
struct ext2_dx_root_info *rootnode;
struct ext2_dx_entry *ent;