2007-08-30 14:31:24

by Andreas Dilger

[permalink] [raw]
Subject: Re: [PATCH V2] fix mballoc oopses on mkdir

On Aug 28, 2007 15:29 -0500, Eric Sandeen wrote:
> Andreas Dilger wrote:
> >> (there are 54 BUGs and BUG_ONs in this file...!)
> >
> > Yes, we like lots of assertions in our code, because it is exceedingly
> > complex to debug otherwise.
> But wouldn't error recovery be a better choice? You could macro-ize it
> to BUG for development purposes if you wanted, I suppose...

No, the goal is if something "impossible" happens you want to stop dead
at that point instead of continuing to work in an unknown environment.
I believe that all of the extents/mballoc code will NOT BUG on bad data
from disk.

Cheers, Andreas
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.