/usr/src/devel/fs/ext4/mballoc.c: In function 'mb_find_next_bit':
/usr/src/devel/fs/ext4/mballoc.c:399: error: implicit declaration of function 'generic_find_next_le_bit'
This has been happening for months.
On Thu, 22 May 2008 23:54:41 -0700 Andrew Morton <[email protected]> wrote:
> Subject: ext4 still busted on ext4
err, on m68k.
> /usr/src/devel/fs/ext4/mballoc.c: In function 'mb_find_next_bit':
> /usr/src/devel/fs/ext4/mballoc.c:399: error: implicit declaration of function 'generic_find_next_le_bit'
>
> This has been happening for months.
Is there anything wrong with the obvious fix (below)? I don't have a
way to even compile-test this...
Honza
--
Jan Kara <[email protected]>
SuSE CR Labs
---
From: Jan Kara <[email protected]>
Subject: [PATCH] m68k: Fix compilation warning
/usr/src/devel/fs/ext4/mballoc.c: In function 'mb_find_next_bit':
/usr/src/devel/fs/ext4/mballoc.c:399: error: implicit declaration of function 'generic_find_next_le_bit'
Signed-off-by: Jan Kara <[email protected]>
---
include/asm-m68k/bitops.h | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/include/asm-m68k/bitops.h b/include/asm-m68k/bitops.h
index 83d1f28..bb3a2fa 100644
--- a/include/asm-m68k/bitops.h
+++ b/include/asm-m68k/bitops.h
@@ -13,6 +13,7 @@
#endif
#include <linux/compiler.h>
+#include <asm-generic/bitops.h>
/*
* Require 68020 or better.
--
1.5.2.4
On Thu, 29 May 2008, Jan Kara wrote:
> > /usr/src/devel/fs/ext4/mballoc.c: In function 'mb_find_next_bit':
> > /usr/src/devel/fs/ext4/mballoc.c:399: error: implicit declaration of function 'generic_find_next_le_bit'
> >
> > This has been happening for months.
> Is there anything wrong with the obvious fix (below)? I don't have a
> way to even compile-test this...
Yes. Including the header only provides the prototype of
generic_find_next_le_bit(), not the actual implementation. So it will
still fail at link time.
There exists a patch to fix it, but I haven't tested it yet. Will do (when
time permits), hopefully before 2.6.26...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds