2009-06-22 20:52:30

by Roel Kluin

Subject: [PATCH] ext4: remove redundant test on unsigned

unsigned i_block cannot be less than 0.

Signed-off-by: Roel Kluin <[email protected]>
---
Maybe a test `if (i_block > MAX)' but what should MAX be?

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 7c17ae2..3cd567d 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -343,9 +343,7 @@ static int ext4_block_to_path(struct inode *inode,
int n = 0;
int final = 0;

- if (i_block < 0) {
- ext4_warning(inode->i_sb, "ext4_block_to_path", "block < 0");
- } else if (i_block < direct_blocks) {
+ if (i_block < direct_blocks) {
offsets[n++] = i_block;
final = direct_blocks;
} else if ((i_block -= direct_blocks) < indirect_blocks) {

2009-08-11 13:02:44

by Theodore Ts'o

Subject: Re: [PATCH] ext4: remove redundant test on unsigned

On Tue, Jun 23, 2009 at 12:53:07AM +0200, Roel Kluin wrote:
> unsigned i_block cannot be less than 0.
>
> Signed-off-by: Roel Kluin <[email protected]>

Applied, my apologies for the delay.

- Ted