On Sun, 28 Jun 2009 09:34:30 -0400, Theodore Tso <[email protected]> wrote:
> I'll have a corrected patch checked into e2fsprogs.
Hi,
I get the following output when trying to compile e2fsprogs-1.41.7
against util-linux-ng-2.16-rc1's installed versions of libuuid &
libblkid:
CC ../../e2fsck/profile.c
CC prof_err.c
make[3]: *** No rule to make target `-L/tools/lib', needed by `e2fsck'. Stop.
make[3]: Leaving directory `/mnt/lfs/sources/e2fsprogs-1.41.7/build/e2fsck'
make[2]: *** [all-progs-recursive] Error 1
make[2]: Leaving directory `/mnt/lfs/sources/e2fsprogs-1.41.7/build'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/mnt/lfs/sources/e2fsprogs-1.41.7/build'
This was after doing:
../configure --prefix=/tools --disable-libblkid --disable-libuuid
This appears to stem from the following bits of the Makefile:
e2fsck: $(OBJS) $(DEPLIBS)
DEPLIBS= $(LIBEXT2FS) $(LIBCOM_ERR) $(DEPLIBBLKID) $(DEPLIBUUID) $(DEPLIBE2P)
DEPLIBBLKID = $(LIBUUID)
LIBUUID = -L/tools/lib -luuid
So, DEPLIBBLKID appears to be getting set even if the building of libuuid &
libblkid has been disabled. Should DEPLIBBLKID & DEPLIBUUID even be included
in DEPLIBS in that circumstance?
Thanks,
Matt.
On Wed, Jul 01, 2009 at 03:04:43PM -0600, Matthew Burgess wrote:
> On Sun, 28 Jun 2009 09:34:30 -0400, Theodore Tso <[email protected]> wrote:
>
> > I'll have a corrected patch checked into e2fsprogs.
>
> Hi,
>
> I get the following output when trying to compile e2fsprogs-1.41.7
> against util-linux-ng-2.16-rc1's installed versions of libuuid &
> libblkid
Thanks for pointing that out. Apparently GNU make wasn't failing when
"-luuid" was in the dependency, which is why I didn't notice this
earlier. I'm not sure why it complains with "-L/tools/lib", but not
with "-luuid", but whatever. I've checked the following into the
e2fsprogs maint branch.
- Ted
commit 4a1e15a8babb2176a427f40c92b7ac1e3bf7346d
Author: Theodore Ts'o <[email protected]>
Date: Wed Jul 1 17:20:24 2009 -0400
Fix compilation problem when building with --disable-uuid
The MCONFIG.in file used $(LIBUUID) in the definition of DEPLIBBLKID,
when it should have used $(DEPLIBUUID) instead.
Signed-off-by: "Theodore Ts'o" <[email protected]>
diff --git a/MCONFIG.in b/MCONFIG.in
index cec3631..9596e56 100644
--- a/MCONFIG.in
+++ b/MCONFIG.in
@@ -79,7 +79,7 @@ LIBBLKID = @LIBBLKID@ @PRIVATE_LIBS_CMT@ $(LIBUUID)
LIBINTL = @LIBINTL@
DEPLIBSS = $(LIB)/libss@LIB_EXT@
DEPLIBUUID = @DEPLIBUUID@
-DEPLIBBLKID = @DEPLIBBLKID@ @PRIVATE_LIBS_CMT@ $(LIBUUID)
+DEPLIBBLKID = @DEPLIBBLKID@ @PRIVATE_LIBS_CMT@ $(DEPLIBUUID)
STATIC_LIBSS = $(LIB)/libss@STATIC_LIB_EXT@ @DLOPEN_LIB@
STATIC_LIBCOM_ERR = $(LIB)/libcom_err@STATIC_LIB_EXT@ @SEM_INIT_LIB@