2009-12-07 13:50:33

by Roel Kluin

Subject: [PATCH] ext4: PTR_ERR return of wrong pointer in setup_new_group_blocks()

Return the PTR_ERR of the correct pointer.

Signed-off-by: Roel Kluin <[email protected]>
---
fs/ext4/resize.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 3cfc343..3b2c554 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -247,7 +247,7 @@ static int setup_new_group_blocks(struct super_block *sb,
goto exit_bh;

if (IS_ERR(gdb = bclean(handle, sb, block))) {
- err = PTR_ERR(bh);
+ err = PTR_ERR(gdb);
goto exit_bh;
}
ext4_handle_dirty_metadata(handle, NULL, gdb);

2009-12-07 15:37:50

by Theodore Ts'o

Subject: Re: [PATCH] ext4: PTR_ERR return of wrong pointer in setup_new_group_blocks()

On Mon, Dec 07, 2009 at 02:51:47PM +0100, Roel Kluin wrote:
> Return the PTR_ERR of the correct pointer.
>
> Signed-off-by: Roel Kluin <[email protected]>

Signed-off-by: "Theodore Ts'o" <[email protected]>

- Ted