2010-09-26 06:31:10

by Namhyung Kim

Subject: [PATCH] ext2: fix comment on ext2_try_to_allocate()

@handle doesn't exist in ext2. Remove it.
Also, fit comment header into kernel-doc format.

Signed-off-by: Namhyung Kim <[email protected]>
---
fs/ext2/balloc.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
index c6c684b..0d06f4e 100644
--- a/fs/ext2/balloc.c
+++ b/fs/ext2/balloc.c
@@ -646,10 +646,9 @@ find_next_usable_block(int start, struct buffer_head *bh, int maxblocks)
return here;
}

-/*
+/**
* ext2_try_to_allocate()
* @sb: superblock
- * @handle: handle to this transaction
* @group: given allocation block group
* @bitmap_bh: bufferhead holds the block bitmap
* @grp_goal: given target block within the group
--
1.7.2.2

2010-09-27 17:09:24

by Jan Kara

Subject: Re: [PATCH] ext2: fix comment on ext2_try_to_allocate()

On Sun 26-09-10 15:31:00, Namhyung Kim wrote:
> @handle doesn't exist in ext2. Remove it.
> Also, fit comment header into kernel-doc format.
>
> Signed-off-by: Namhyung Kim <[email protected]>
Thanks. I've merged it in my tree.

Honza
> ---
> fs/ext2/balloc.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ext2/balloc.c b/fs/ext2/balloc.c
> index c6c684b..0d06f4e 100644
> --- a/fs/ext2/balloc.c
> +++ b/fs/ext2/balloc.c
> @@ -646,10 +646,9 @@ find_next_usable_block(int start, struct buffer_head *bh, int maxblocks)
> return here;
> }
>
> -/*
> +/**
> * ext2_try_to_allocate()
> * @sb: superblock
> - * @handle: handle to this transaction
> * @group: given allocation block group
> * @bitmap_bh: bufferhead holds the block bitmap
> * @grp_goal: given target block within the group
> --
> 1.7.2.2
>
--
Jan Kara <[email protected]>
SUSE Labs, CR