2010-10-04 15:13:59

by Namhyung Kim

Subject: [PATCH] jbd: Remove unnecessary goto statement

Remove goto statement which jumps to very next line. Also remove
target label because it is no longer used anywhere.

Signed-off-by: Namhyung Kim <[email protected]>
---
fs/jbd/transaction.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
index 5ae71e7..981449c 100644
--- a/fs/jbd/transaction.c
+++ b/fs/jbd/transaction.c
@@ -293,9 +293,7 @@ handle_t *journal_start(journal_t *journal, int nblocks)
jbd_free_handle(handle);
current->journal_info = NULL;
handle = ERR_PTR(err);
- goto out;
}
-out:
return handle;
}

--
1.7.0.4

2010-10-04 15:58:46

by Jan Kara

Subject: Re: [PATCH] jbd: Remove unnecessary goto statement

On Tue 05-10-10 00:13:59, Namhyung Kim wrote:
> Remove goto statement which jumps to very next line. Also remove
> target label because it is no longer used anywhere.
Thanks. Merged into my tree.

Honza
>
> Signed-off-by: Namhyung Kim <[email protected]>
> ---
> fs/jbd/transaction.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/jbd/transaction.c b/fs/jbd/transaction.c
> index 5ae71e7..981449c 100644
> --- a/fs/jbd/transaction.c
> +++ b/fs/jbd/transaction.c
> @@ -293,9 +293,7 @@ handle_t *journal_start(journal_t *journal, int nblocks)
> jbd_free_handle(handle);
> current->journal_info = NULL;
> handle = ERR_PTR(err);
> - goto out;
> }
> -out:
> return handle;
> }
>
> --
> 1.7.0.4
>
--
Jan Kara <[email protected]>
SUSE Labs, CR