2011-09-23 22:38:42

by Hartley Sweeten

Subject: [PATCH] ext4/xattr_security.c: local functions should be static

Quiets the sparse noise:

warning: symbol 'ext4_initxattrs' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <[email protected]>
Cc: "Theodore Ts'o" <[email protected]>
Cc: Andreas Dilger <[email protected]>

---

diff --git a/fs/ext4/xattr_security.c b/fs/ext4/xattr_security.c
index 34e4350..827fbfd 100644
--- a/fs/ext4/xattr_security.c
+++ b/fs/ext4/xattr_security.c
@@ -48,7 +48,7 @@ ext4_xattr_security_set(struct dentry *dentry, const char *name,
name, value, size, flags);
}

-int ext4_initxattrs(struct inode *inode, const struct xattr *xattr_array,
+static int ext4_initxattrs(struct inode *inode, const struct xattr *xattr_array,
void *fs_info)
{
const struct xattr *xattr;

2011-10-12 03:09:25

by Theodore Ts'o

Subject: Re: [PATCH] ext4/xattr_security.c: local functions should be static

On Fri, Sep 23, 2011 at 03:38:22PM -0700, H Hartley Sweeten wrote:
> Quiets the sparse noise:
>
> warning: symbol 'ext4_initxattrs' was not declared. Should it be static?

What version of the kernel was this from? I can't find
ext4_initxattrs in any kernel version that I can find in git...

- Ted