2012-03-28 08:32:32

by Stefan Hajnoczi

[permalink] [raw]
Subject: [PATCH] ext3: update documentation with barrier=1 default

Commit 00eacd6 ("ext3: make ext3 mount default to barrier=1") changed
the default barrier mount option for ext3. The documentation needs to
be updated, so this patch does that.

Signed-off-by: Stefan Hajnoczi <[email protected]>
---
Documentation/filesystems/ext3.txt | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/filesystems/ext3.txt b/Documentation/filesystems/ext3.txt
index b100adc..293855e 100644
--- a/Documentation/filesystems/ext3.txt
+++ b/Documentation/filesystems/ext3.txt
@@ -59,9 +59,9 @@ commit=nrsec (*) Ext3 can be told to sync all its data and metadata
Setting it to very large values will improve
performance.

-barrier=<0(*)|1> This enables/disables the use of write barriers in
-barrier the jbd code. barrier=0 disables, barrier=1 enables.
-nobarrier (*) This also requires an IO stack which can support
+barrier=<0|1(*)> This enables/disables the use of write barriers in
+barrier (*) the jbd code. barrier=0 disables, barrier=1 enables.
+nobarrier This also requires an IO stack which can support
barriers, and if jbd gets an error on a barrier
write, it will disable again with a warning.
Write barriers enforce proper on-disk ordering
--
1.7.9.1



2012-03-28 12:49:32

by Christoph Hellwig

[permalink] [raw]
Subject: Re: [PATCH] ext3: update documentation with barrier=1 default

On Wed, Mar 28, 2012 at 09:32:32AM +0100, Stefan Hajnoczi wrote:
> Commit 00eacd6 ("ext3: make ext3 mount default to barrier=1") changed
> the default barrier mount option for ext3. The documentation needs to
> be updated, so this patch does that.

Looks good,

Reviewed-by: Christoph Hellwig <[email protected]>

2012-03-29 15:29:44

by Jan Kara

[permalink] [raw]
Subject: Re: [PATCH] ext3: update documentation with barrier=1 default

On Wed 28-03-12 14:49:32, Christoph Hellwig wrote:
> On Wed, Mar 28, 2012 at 09:32:32AM +0100, Stefan Hajnoczi wrote:
> > Commit 00eacd6 ("ext3: make ext3 mount default to barrier=1") changed
> > the default barrier mount option for ext3. The documentation needs to
> > be updated, so this patch does that.
>
> Looks good,
>
> Reviewed-by: Christoph Hellwig <[email protected]>
Thanks. I've added the patch to my tree.

Honza
--
Jan Kara <[email protected]>
SUSE Labs, CR