2013-06-17 00:05:46

by jon ernst

[permalink] [raw]
Subject: [PATCH] ext4: delete unused variables

This patch removed several unused variables.

Signed-off-by: Jon Ernst <[email protected]>
---


diff --git a/fs/ext4/move_extent.c b/fs/ext4/move_extent.c
index 3dcbf36..b494382 100644
--- a/fs/ext4/move_extent.c
+++ b/fs/ext4/move_extent.c
@@ -912,7 +912,6 @@ move_extent_per_page(struct file *o_filp, struct inode *donor_inode,
       struct page *pagep[2] = {NULL, NULL};
       handle_t *handle;
       ext4_lblk_t orig_blk_offset;
-       long long offs = orig_page_offset << PAGE_CACHE_SHIFT;
       unsigned long blocksize = orig_inode->i_sb->s_blocksize;
       unsigned int w_flags = 0;
       unsigned int tmp_data_size, data_size, replaced_size;
@@ -940,7 +939,6 @@ again:
       orig_blk_offset = orig_page_offset * blocks_per_page +
               data_offset_in_page;

-       offs = (long long)orig_blk_offset << orig_inode->i_blkbits;

       /* Calculate data_size */
       if ((orig_blk_offset + block_len_in_page - 1) ==
diff --git a/fs/ext4/resize.c b/fs/ext4/resize.c
index 6ed4df2..707095b 100644
--- a/fs/ext4/resize.c
+++ b/fs/ext4/resize.c
@@ -1556,11 +1556,10 @@ int ext4_group_add(struct super_block *sb, struct ext4_new_group_data *input)
       int reserved_gdb = ext4_bg_has_super(sb, input->group) ?
               le16_to_cpu(es->s_reserved_gdt_blocks) : 0;
       struct inode *inode = NULL;
-       int gdb_off, gdb_num;
+       int gdb_off;
       int err;
       __u16 bg_flags = 0;

-       gdb_num = input->group / EXT4_DESC_PER_BLOCK(sb);
       gdb_off = input->group % EXT4_DESC_PER_BLOCK(sb);

       if (gdb_off == 0 && !EXT4_HAS_RO_COMPAT_FEATURE(sb,
diff --git a/fs/ext4/super.c b/ext4/fs/super.c
index eb52a7b..54701fc 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1924,7 +1924,6 @@ static int ext4_fill_flex_info(struct super_block *sb)
       struct ext4_sb_info *sbi = EXT4_SB(sb);
       struct ext4_group_desc *gdp = NULL;
       ext4_group_t flex_group;
-       unsigned int groups_per_flex = 0;
       int i, err;

       sbi->s_log_groups_per_flex = sbi->s_es->s_log_groups_per_flex;
@@ -1932,7 +1931,6 @@ static int ext4_fill_flex_info(struct super_block *sb)
               sbi->s_log_groups_per_flex = 0;
               return 1;
       }
-       groups_per_flex = 1U << sbi->s_log_groups_per_flex;

       err = ext4_alloc_flex_bg_array(sb, sbi->s_groups_count);
       if (err)
               


2013-06-17 12:57:33

by Theodore Ts'o

[permalink] [raw]
Subject: Re: [PATCH] ext4: delete unused variables

On Sun, Jun 16, 2013 at 08:05:43PM -0400, jon ernst wrote:
> This patch removed several unused variables.
>
> Signed-off-by: Jon Ernst <[email protected]>

Applied, thanks. BTW, your patch was corrupted by your Mail User
Agent. (It was sent in UTF-8 and with strange character set
conversions.)

- Ted