2018-01-24 03:33:22

by Tyson Nottingham

Subject: [PATCH] debugfs: remove misplaced "MMP is unsupported" message.

This message was inadvertently copied from the version of do_dump_mmp
that is used when CONFIG_MMP is disabled.

Signed-off-by: Tyson Nottingham <[email protected]>
---
debugfs/debugfs.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
index 91ededf..e46532f 100644
--- a/debugfs/debugfs.c
+++ b/debugfs/debugfs.c
@@ -2366,8 +2366,6 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[])
fprintf(stdout, "device_name: %s\n", mmp_s->mmp_bdevname);
fprintf(stdout, "magic: 0x%x\n", mmp_s->mmp_magic);
fprintf(stdout, "checksum: 0x%08x\n", mmp_s->mmp_checksum);
- fprintf(stdout, "MMP is unsupported, please recompile with "
- "--enable-mmp\n");
}
#else
void do_dump_mmp(int argc EXT2FS_ATTR((unused)),
--
2.7.4

2018-01-24 05:04:29

by Darrick J. Wong

Subject: Re: [PATCH] debugfs: remove misplaced "MMP is unsupported" message.

On Tue, Jan 23, 2018 at 07:33:17PM -0800, Tyson Nottingham wrote:
> This message was inadvertently copied from the version of do_dump_mmp
> that is used when CONFIG_MMP is disabled.
>
> Signed-off-by: Tyson Nottingham <[email protected]>

Looks ok,
Reviewed-by: Darrick J. Wong <[email protected]>

> ---
> debugfs/debugfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/debugfs/debugfs.c b/debugfs/debugfs.c
> index 91ededf..e46532f 100644
> --- a/debugfs/debugfs.c
> +++ b/debugfs/debugfs.c
> @@ -2366,8 +2366,6 @@ void do_dump_mmp(int argc EXT2FS_ATTR((unused)), char *argv[])
> fprintf(stdout, "device_name: %s\n", mmp_s->mmp_bdevname);
> fprintf(stdout, "magic: 0x%x\n", mmp_s->mmp_magic);
> fprintf(stdout, "checksum: 0x%08x\n", mmp_s->mmp_checksum);
> - fprintf(stdout, "MMP is unsupported, please recompile with "
> - "--enable-mmp\n");
> }
> #else
> void do_dump_mmp(int argc EXT2FS_ATTR((unused)),
> --
> 2.7.4
>

2018-02-08 04:28:58

by Theodore Ts'o

Subject: Re: [PATCH] debugfs: remove misplaced "MMP is unsupported" message.

On Tue, Jan 23, 2018 at 07:33:17PM -0800, Tyson Nottingham wrote:
> This message was inadvertently copied from the version of do_dump_mmp
> that is used when CONFIG_MMP is disabled.
>
> Signed-off-by: Tyson Nottingham <[email protected]>

Thanks, applied.

- Ted