2020-04-23 02:46:06

by Yasunori Gotou (Fujitsu)

Subject: Re: [PATCH V10 04/11] Documentation/dax: Update Usage section

Hello,

I'm trying use your patch now, and I have a small comment in this document.

On 2020/04/23 6:20, [email protected] wrote:

> +To clarify inheritance here are 3 examples:
> +
> +Example A:
> +
> +mkdir -p a/b/c
> +xfs_io 'chattr +x' a

Probably, "-c" is necessary here.

xfs_io -c 'chattr +x' a


> +mkdir a/b/c/d
> +mkdir a/e
> +
> + dax: a,e
> + no dax: b,c,d
> +
> +Example B:
> +
> +mkdir a
> +xfs_io 'chattr +x' a
ditto
> +mkdir -p a/b/c/d
> +
> + dax: a,b,c,d
> + no dax:
> +
> +Example C:
> +
> +mkdir -p a/b/c
> +xfs_io 'chattr +x' c
ditto
> +mkdir a/b/c/d
> +
> + dax: c,d
> + no dax: a,b
> +
> +

---

Yasunori Goto

2020-04-23 05:06:43

by Ira Weiny

Subject: Re: [PATCH V10 04/11] Documentation/dax: Update Usage section

On Thu, Apr 23, 2020 at 11:33:26AM +0900, Yasunori Goto wrote:
> Hello,
>
> I'm trying use your patch now, and I have a small comment in this document.
>
> On 2020/04/23 6:20, [email protected] wrote:
>
> > +To clarify inheritance here are 3 examples:
> > +
> > +Example A:
> > +
> > +mkdir -p a/b/c
> > +xfs_io 'chattr +x' a
>
> Probably, "-c" is necessary here.
>
> xfs_io -c 'chattr +x' a

Yes! Thanks!
>
>
> > +mkdir a/b/c/d
> > +mkdir a/e
> > +
> > + dax: a,e
> > + no dax: b,c,d
> > +
> > +Example B:
> > +
> > +mkdir a
> > +xfs_io 'chattr +x' a
> ditto
> > +mkdir -p a/b/c/d
> > +
> > + dax: a,b,c,d
> > + no dax:
> > +
> > +Example C:
> > +
> > +mkdir -p a/b/c
> > +xfs_io 'chattr +x' c
> ditto

Thank you! Updated.
Ira

> > +mkdir a/b/c/d
> > +
> > + dax: c,d
> > + no dax: a,b
> > +
> > +
>
> ---
>
> Yasunori Goto
>