2022-03-23 10:00:05

by baihaowen

Subject: [PATCH] fs: ext4: Fix duplicate included linux/dax.h

Clean up the following includecheck warning:

fs/ext4/inode.c: linux/dax.h is included more than once.

No functional change.

Signed-off-by: Haowen Bai <[email protected]>
---
fs/ext4/inode.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 01c9e4f..6738ea7 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -41,7 +41,6 @@
#include <linux/bitops.h>
#include <linux/iomap.h>
#include <linux/iversion.h>
-#include <linux/dax.h>

#include "ext4_jbd2.h"
#include "xattr.h"
--
2.7.4

2022-03-24 02:04:13

by Ritesh Harjani

Subject: Re: [PATCH] fs: ext4: Fix duplicate included linux/dax.h

On 22/03/23 11:49AM, Haowen Bai wrote:
> Clean up the following includecheck warning:
>
> fs/ext4/inode.c: linux/dax.h is included more than once.

Checked "make includecheck"
This is the only warning coming from fs/ext4/

Thanks for fixing that. Looks good to me.
Feel free to add -

Reviewed-by: Ritesh Harjani <[email protected]>



>
> No functional change.
>
> Signed-off-by: Haowen Bai <[email protected]>
> ---
> fs/ext4/inode.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index 01c9e4f..6738ea7 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -41,7 +41,6 @@
> #include <linux/bitops.h>
> #include <linux/iomap.h>
> #include <linux/iversion.h>
> -#include <linux/dax.h>
>
> #include "ext4_jbd2.h"
> #include "xattr.h"
> --
> 2.7.4
>