2022-10-09 03:28:18

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] ext4: remove deprecated_msg

fs/ext4/super.c:1744:19: warning: ‘deprecated_msg’ defined but not used.

Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2346
Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
fs/ext4/super.c | 4 ----
1 file changed, 4 deletions(-)

diff --git a/fs/ext4/super.c b/fs/ext4/super.c
index 989365b878a6..7950904fbf04 100644
--- a/fs/ext4/super.c
+++ b/fs/ext4/super.c
@@ -1741,10 +1741,6 @@ static const struct fs_parameter_spec ext4_param_specs[] = {

#define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3))

-static const char deprecated_msg[] =
- "Mount option \"%s\" will be removed by %s\n"
- "Contact [email protected] if you think we should keep it.\n";
-
#define MOPT_SET 0x0001
#define MOPT_CLEAR 0x0002
#define MOPT_NOSUPPORT 0x0004
--
2.20.1.7.g153144c


2022-10-10 11:21:00

by Ojaswin Mujoo

[permalink] [raw]
Subject: Re: [PATCH] ext4: remove deprecated_msg

On Sun, Oct 09, 2022 at 11:25:20AM +0800, Jiapeng Chong wrote:
> fs/ext4/super.c:1744:19: warning: ‘deprecated_msg’ defined but not used.
>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2346
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>
> ---
> fs/ext4/super.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/fs/ext4/super.c b/fs/ext4/super.c
> index 989365b878a6..7950904fbf04 100644
> --- a/fs/ext4/super.c
> +++ b/fs/ext4/super.c
> @@ -1741,10 +1741,6 @@ static const struct fs_parameter_spec ext4_param_specs[] = {
>
> #define DEFAULT_JOURNAL_IOPRIO (IOPRIO_PRIO_VALUE(IOPRIO_CLASS_BE, 3))
>
> -static const char deprecated_msg[] =
> - "Mount option \"%s\" will be removed by %s\n"
> - "Contact [email protected] if you think we should keep it.\n";
> -
> #define MOPT_SET 0x0001
> #define MOPT_CLEAR 0x0002
> #define MOPT_NOSUPPORT 0x0004
> --
> 2.20.1.7.g153144c
>

Hi,

I believe this is a duplicate of:
https://lore.kernel.org/all/[email protected]/

Regards,
ojaswin