2008-06-02 17:57:33

by Sitsofe Wheeler

[permalink] [raw]
Subject: Re: [PATCH] mac80211: fix rate control initialisation

Johannes Berg wrote:

> In commit 2e92e6f2c50b4baf85cca968f0e6f1b5c0df7d39 ("mac80211: use rate
> index in TX control") I forgot to initialise a few new variables to -1
> which means that the rate control algorithm is never triggered and 0 is
> used as the only rate index, effectively fixing the transmit bitrate at
> the lowest supported.
>
> This patch adds the missing initialisation.

This is far better (the rate sets itself to 24Mb/s or 36 Mb/s rather than
being fixed on 54 Mb/s). However when using iwl3945 the rate could not be
forced using iwconfig wlan0 rate 54M fixed and it took a little . The rate
it chooses also seems to bounce about a bit - simply telling networkmanager
to reconnect results in a different speed (although it's hard to tell how
good the connection is while this is happening).

--
Sitsofe | http://sucs.org/~sits/



2008-06-03 08:24:35

by Filippo Zangheri

[permalink] [raw]
Subject: Re: [PATCH] mac80211: fix rate control initialisation

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Sitsofe and everybody,

Sitsofe Wheeler ha scritto:
> This is far better (the rate sets itself to 24Mb/s or 36 Mb/s rather than
> being fixed on 54 Mb/s). However when using iwl3945 the rate could not be
> forced using iwconfig wlan0 rate 54M fixed and it took a little . The rate

Here I have the same behaviour with iwl3945 from
compat-wireless-2008-06-03, I cannot force the bitrate with iwconfig
(Wireless-Tools v29).

But the interface automatically sets the speed to 54M. And it worked
nominally even before this latest patch by Johannes. I'm pretty
near the access point's antenna; signal strength varies between 99%
and 100% and noise power oscillates between -24 and -19 dBm.

So, maybe, the problem does not reside in the device driver?

Best regards.

- --
Filippo Zangheri

GPG key ID: 0x6C1F2F2F
Key fingerprint: E0A6 2A28 04EF EE13 5C5F 8BB8 8F3C 4C1B 6C1F 2F2F
Key server: pgp.mit.edu

- -----BEGIN GEEK CODE BLOCK-----
Version: 3.12
GE d- s+:- a-- C++ UL+++ P+ L+++ E-- W+ N* o-- K- w--- O-- M--
V- PS++ PE+ Y+ PGP++ t 5-- X++ R* tv b+ DI-- D---- G-- e++ h--
r++ z*
- ------END GEEK CODE BLOCK------
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)

iD8DBQFIRP+/jzxMG2wfLy8RApbpAJ9JuyRPjBfn5h+cnIvJKL1W8LPotACdFe9G
BDW2z00i8j1Djt6xzTz6LiM=
=egTP
-----END PGP SIGNATURE-----