2008-10-23 06:46:34

by Sujith

[permalink] [raw]

Subject: [PATCH] mac80211: Change WARN_ON to WARN_ON_ONCE

---

A warning would be printed for every packet that
is transmitted if the rate control information isn't
setup. Change this to WARN_ON_ONCE.

Signed-off-by: Sujith <[email protected]>
---
net/mac80211/tx.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index 8b56048..3678325 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -565,8 +565,8 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx)
IEEE80211_TX_RC_USE_RTS_CTS;

/* RC is busted */
- if (WARN_ON(info->control.rates[i].idx >=
- sband->n_bitrates)) {
+ if (WARN_ON_ONCE(info->control.rates[i].idx >=
+ sband->n_bitrates)) {
info->control.rates[i].idx = -1;
continue;
}
--
1.6.0.2

2008-10-23 06:52:47

by Johannes Berg

[permalink] [raw]

Subject: Re: [PATCH] mac80211: Change WARN_ON to WARN_ON_ONCE

---

On Thu, 2008-10-23 at 12:14 +0530, Sujith wrote:
> A warning would be printed for every packet that
> is transmitted if the rate control information isn't
> setup. Change this to WARN_ON_ONCE.

> Signed-off-by: Sujith <[email protected]>

Acked-by: Johannes Berg <[email protected]>

but please do set up the rate control information to fix the
fragmentation issue etc. :)

> ---
> net/mac80211/tx.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index 8b56048..3678325 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -565,8 +565,8 @@ ieee80211_tx_h_rate_ctrl(struct ieee80211_tx_data *tx)
> IEEE80211_TX_RC_USE_RTS_CTS;
>
> /* RC is busted */
> - if (WARN_ON(info->control.rates[i].idx >=
> - sband->n_bitrates)) {
> + if (WARN_ON_ONCE(info->control.rates[i].idx >=
> + sband->n_bitrates)) {
> info->control.rates[i].idx = -1;
> continue;
> }

---

Attachments:

signature.asc (836.00 B)
This is a digitally signed message part