2009-09-14 18:52:36

by Fabian Lenz

[permalink] [raw]
Subject: missing device id in ar9170 driver

Hello! A quick note: device id 1002 for my TP-LINK TL-WN821N stick is missing,
please include it in the driver.

Regards!



2009-09-15 08:54:03

by Christian Lamparter

[permalink] [raw]
Subject: Re: [RFC] ar9170usb: add ar9170 usbid

On Tuesday 15 September 2009 01:39:40 Stephen Chen wrote:
> Hi Christian,
>
> I could not find this VID/PID in INF file in Windows release.
> This ID combination could be obsolete.

you can get their vendor driver from here:
http://www.tp-link.com/support/download.asp?a=1&m=TL-WN821N

-> Driver Files/XP/arusb_xp.inf
--- snip --- Driver Files/${OS}/arusb_${OS}.inf
%ATHR.DeviceDesc.9170% = ATHRXP9170.ndi, USB\VID_0CF3&PID_1002
ATHR.DeviceDesc.9170 = "TP-LINK TL-WN821N 11N Wireless Adapter"
--- snip ---

Looks like they are trying to hijack Atheros' usbid space
by assigning custom product IDs.

This can confuse the unsuspected user and maybe break some stuff.
I'm not joking, this is an accident waiting to happen!
(see "rt2500usb vs. rt73usb" => http://patchwork.kernel.org/patch/45342/
for how this can go wrong.)

For now, you/[Atheros] should add the PID to your win driver as well
(so it's marked as _used_) and get in touch with TP-Link to come up
with a way for vendors - w/o their own VID - to get custom PIDs.

Regards,
Chr

2009-09-14 23:45:10

by Stephen Chen

[permalink] [raw]
Subject: RE: [RFC] ar9170usb: add ar9170 usbid

Hi Christian,

I could not find this VID/PID in INF file in Windows release.
This ID combination could be obsolete.
Thank you!

Stephen
-----Original Message-----
From: Christian Lamparter [mailto:[email protected]]
Sent: Tuesday, September 15, 2009 5:08 AM
To: Fabian Lenz
Cc: [email protected]; Luis Rodriguez; Stephen Chen
Subject: [RFC] ar9170usb: add ar9170 usbid

Reported-by: Fabian Lenz <[email protected]>
Signed-off-by: Christian Lamparter <[email protected]>
---
Stephen,

- since 0x0cf3 is Atheros' vendor id - can you please lookup the real product
code name for 0x0cf3:0x1002.

I will take care of the re-spin and update the wiki.

Thanks,
Chr
---
diff --git a/drivers/net/wireless/ath/ar9170/usb.c b/drivers/net/wireless/ath/ar9170/usb.c
index e0138ac..68b0bda 100644
--- a/drivers/net/wireless/ath/ar9170/usb.c
+++ b/drivers/net/wireless/ath/ar9170/usb.c
@@ -64,6 +64,8 @@ static struct usb_device_id ar9170_usb_ids[] = {
{ USB_DEVICE(0x0cf3, 0x9170) },
/* Atheros TG121N */
{ USB_DEVICE(0x0cf3, 0x1001) },
+ /* Atheros - Unknown Product Name - */
+ { USB_DEVICE(0x0cf3, 0x1002) },
/* Cace Airpcap NX */
{ USB_DEVICE(0xcace, 0x0300) },
/* D-Link DWA 160A */

2009-09-14 21:08:22

by Christian Lamparter

[permalink] [raw]
Subject: [RFC] ar9170usb: add ar9170 usbid

Reported-by: Fabian Lenz <[email protected]>
Signed-off-by: Christian Lamparter <[email protected]>
---
Stephen,

- since 0x0cf3 is Atheros' vendor id - can you please lookup the real product
code name for 0x0cf3:0x1002.

I will take care of the re-spin and update the wiki.

Thanks,
Chr
---
diff --git a/drivers/net/wireless/ath/ar9170/usb.c b/drivers/net/wireless/ath/ar9170/usb.c
index e0138ac..68b0bda 100644
--- a/drivers/net/wireless/ath/ar9170/usb.c
+++ b/drivers/net/wireless/ath/ar9170/usb.c
@@ -64,6 +64,8 @@ static struct usb_device_id ar9170_usb_ids[] = {
{ USB_DEVICE(0x0cf3, 0x9170) },
/* Atheros TG121N */
{ USB_DEVICE(0x0cf3, 0x1001) },
+ /* Atheros - Unknown Product Name - */
+ { USB_DEVICE(0x0cf3, 0x1002) },
/* Cace Airpcap NX */
{ USB_DEVICE(0xcace, 0x0300) },
/* D-Link DWA 160A */