From: Ming Lei <[email protected]>
If split tkip key is used, ath_delete_key should delete
rx key and rx mic key. This patch fixes the leak of hw
keycache in the case.
---
The patch is against the latest wireless test tree.
Signed-off-by: Ming Lei <[email protected]>
---
drivers/net/wireless/ath/ath9k/main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 6796d5c..928402b 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -809,6 +809,7 @@ static void ath_key_delete(struct ath_common *common, struct ieee80211_key_conf
clear_bit(key->hw_key_idx + 64, common->keymap);
if (common->splitmic) {
+ ath9k_hw_keyreset(ah, key->hw_key_idx + 32);
clear_bit(key->hw_key_idx + 32, common->keymap);
clear_bit(key->hw_key_idx + 64 + 32, common->keymap);
}
--
1.6.2.5
On Sat, Feb 6, 2010 at 6:38 AM, <[email protected]> wrote:
> From: Ming Lei <[email protected]>
>
> If split tkip key is used, ath_delete_key should delete
> rx key and rx mic key. This patch fixes the leak of hw
> keycache in the case.
Can you please resend with Cc: [email protected] on the commit log entry?
> ---
> The patch is against the latest wireless test tree.
>
> Signed-off-by: Ming Lei <[email protected]>
Luis
>From 67b0faf7e7a57c3e6a971ff43d1f03f8e939429b Mon Sep 17 00:00:00 2001
From: Ming Lei <[email protected]>
Date: Sat, 6 Feb 2010 22:30:53 +0800
Subject: [PATCH] ath9k: fix keycache leak in split tkip case
If split tkip key is used, ath_delete_key should delete
rx key and rx mic key. This patch fixes the leak of hw
keycache in the case.
Signed-off-by: Ming Lei <[email protected]>
Cc: [email protected]
---
The patch is against the latest wireless test tree.
Thanks for the comments of Luis and johannes.
---
drivers/net/wireless/ath/ath9k/main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 6796d5c..928402b 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -809,6 +809,7 @@ static void ath_key_delete(struct ath_common *common, struct ieee80211_key_conf
clear_bit(key->hw_key_idx + 64, common->keymap);
if (common->splitmic) {
+ ath9k_hw_keyreset(ah, key->hw_key_idx + 32);
clear_bit(key->hw_key_idx + 32, common->keymap);
clear_bit(key->hw_key_idx + 64 + 32, common->keymap);
}
--
1.6.2.5
On Tue, 09 Feb 2010 08:51:48 +0100
Johannes Berg <[email protected]> wrote:
> On Tue, 2010-02-09 at 09:36 +0800, Ming Lei wrote:
> > From 67b0faf7e7a57c3e6a971ff43d1f03f8e939429b Mon Sep 17 00:00:00
> > 2001 From: Ming Lei <[email protected]>
> > Date: Sat, 6 Feb 2010 22:30:53 +0800
> > Subject: [PATCH] ath9k: fix keycache leak in split tkip case
> >
> > If split tkip key is used, ath_delete_key should delete
> > rx key and rx mic key. This patch fixes the leak of hw
> > keycache in the case.
> >
> > ---
> > The patch is against the latest wireless test tree.
> >
> > Signed-off-by: Ming Lei <[email protected]>
> > Cc: [email protected]
>
> This is ordered wrong, it needs to be
>
> ----------
> From: foo
>
> If split ...
>
> Signed-off-by: ...
> Cc: stable...
> ---
> The patch is against...
> (everything after --- is removed from the commit log when committing)
> ----------
>
> johannes
>
On Mon, Feb 8, 2010 at 10:10 PM, Jinsung Lee <[email protected]> wrote:
> Dear Luis,
>
> Is this tarball also working on kernel 2.6.24?
I think it should work down to 2.6.23 actually for ath9k.
Luis
On Tue, 2010-02-09 at 09:36 +0800, Ming Lei wrote:
> From 67b0faf7e7a57c3e6a971ff43d1f03f8e939429b Mon Sep 17 00:00:00 2001
> From: Ming Lei <[email protected]>
> Date: Sat, 6 Feb 2010 22:30:53 +0800
> Subject: [PATCH] ath9k: fix keycache leak in split tkip case
>
> If split tkip key is used, ath_delete_key should delete
> rx key and rx mic key. This patch fixes the leak of hw
> keycache in the case.
>
> ---
> The patch is against the latest wireless test tree.
>
> Signed-off-by: Ming Lei <[email protected]>
> Cc: [email protected]
This is ordered wrong, it needs to be
----------
From: foo
If split ...
Signed-off-by: ...
Cc: stable...
---
The patch is against...
(everything after --- is removed from the commit log when committing)
----------
johannes
Dear Luis,
Is this tarball also working on kernel 2.6.24?
I've been trying, but it may have some problem.
Thanks.
-Jinsung
-----Original Message-----
From: [email protected] [mailto:[email protected]] On Behalf Of Luis R. Rodriguez
Sent: Tuesday, February 09, 2010 3:02 AM
To: Zhang Yanfei-B21500
Cc: [email protected]; [email protected]
Subject: Re: [ath9k-devel] can ath9k run on linux 2.6.25
On Mon, Feb 8, 2010 at 1:20 AM, Zhang Yanfei-B21500
<[email protected]> wrote:
> Hi All
> Anyone have porting the ath9k to 2.6.25? Is it can work on
> 2.6.25?
>
This tarball has 2.6.25 enabled:
http://www.orbit-lab.org/kernel/compat-wireless-2.6-stable/v2.6.32/compat-wireless-2.6.32.3.tar.bz2
Newer stable kernels after this required multiqueue backported which I
gave a try but haven't gotten reports from users on:
http://bombadil.infradead.org/~mcgrof/tmp/compat-wireless-2.6.32.5-rc3.tar.bz2
After untarring you will have to select to compile only ath9k:
./scripts/driver-select ath9k
Luis
_______________________________________________
ath9k-devel mailing list
[email protected]
https://lists.ath9k.org/mailman/listinfo/ath9k-devel
On Mon, Feb 8, 2010 at 1:20 AM, Zhang Yanfei-B21500
<[email protected]> wrote:
> Hi All
> Anyone have porting the ath9k to 2.6.25? Is it can work on
> 2.6.25?
>
This tarball has 2.6.25 enabled:
http://www.orbit-lab.org/kernel/compat-wireless-2.6-stable/v2.6.32/compat-wireless-2.6.32.3.tar.bz2
Newer stable kernels after this required multiqueue backported which I
gave a try but haven't gotten reports from users on:
http://bombadil.infradead.org/~mcgrof/tmp/compat-wireless-2.6.32.5-rc3.tar.bz2
After untarring you will have to select to compile only ath9k:
./scripts/driver-select ath9k
Luis
>From 67b0faf7e7a57c3e6a971ff43d1f03f8e939429b Mon Sep 17 00:00:00 2001
From: Ming Lei <[email protected]>
Date: Sat, 6 Feb 2010 22:30:53 +0800
Subject: [PATCH] ath9k: fix keycache leak in split tkip case
If split tkip key is used, ath_delete_key should delete
rx key and rx mic key. This patch fixes the leak of hw
keycache in the case.
---
The patch is against the latest wireless test tree.
Signed-off-by: Ming Lei <[email protected]>
Cc: [email protected]
---
drivers/net/wireless/ath/ath9k/main.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 6796d5c..928402b 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -809,6 +809,7 @@ static void ath_key_delete(struct ath_common *common, struct ieee80211_key_conf
clear_bit(key->hw_key_idx + 64, common->keymap);
if (common->splitmic) {
+ ath9k_hw_keyreset(ah, key->hw_key_idx + 32);
clear_bit(key->hw_key_idx + 32, common->keymap);
clear_bit(key->hw_key_idx + 64 + 32, common->keymap);
}
--
1.6.2.5
On Mon, 8 Feb 2010 13:38:02 -0800
"Luis R. Rodriguez" <[email protected]> wrote:
> On Sat, Feb 6, 2010 at 6:38 AM, <[email protected]> wrote:
> > From: Ming Lei <[email protected]>
> >
> > If split tkip key is used, ath_delete_key should delete
> > rx key and rx mic key. This patch fixes the leak of hw
> > keycache in the case.
>
> Can you please resend with Cc: [email protected] on the commit log
> entry?
>
> > ---
> > The patch is against the latest wireless test tree.
> >
> > Signed-off-by: Ming Lei <[email protected]>
>
> Luis
Hi All
Anyone have porting the ath9k to 2.6.25? Is it can work on
2.6.25?
Regards,
Yanfei Zhang
> -----Original Message-----
> From: [email protected]
> [mailto:[email protected]] On Behalf Of
> [email protected]
> Sent: Saturday, February 06, 2010 10:38 PM
> To: [email protected]
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]
> Subject: [ath9k-devel] [PATCH] ath9k: fix keycache leak in
> split tkip case
>
> From: Ming Lei <[email protected]>
>
> If split tkip key is used, ath_delete_key should delete rx
> key and rx mic key. This patch fixes the leak of hw keycache
> in the case.
>
> ---
> The patch is against the latest wireless test tree.
>
> Signed-off-by: Ming Lei <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/main.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/main.c
> b/drivers/net/wireless/ath/ath9k/main.c
> index 6796d5c..928402b 100644
> --- a/drivers/net/wireless/ath/ath9k/main.c
> +++ b/drivers/net/wireless/ath/ath9k/main.c
> @@ -809,6 +809,7 @@ static void ath_key_delete(struct
> ath_common *common, struct ieee80211_key_conf
>
> clear_bit(key->hw_key_idx + 64, common->keymap);
> if (common->splitmic) {
> + ath9k_hw_keyreset(ah, key->hw_key_idx + 32);
> clear_bit(key->hw_key_idx + 32, common->keymap);
> clear_bit(key->hw_key_idx + 64 + 32, common->keymap);
> }
> --
> 1.6.2.5
>
> _______________________________________________
> ath9k-devel mailing list
> [email protected]
> https://lists.ath9k.org/mailman/listinfo/ath9k-devel
>
>