2010-11-23 16:10:18

by Guennadi Liakhovetski

Subject: [PATCH] wireless: b43: fix error path in SDIO

Fix unbalanced call to sdio_release_host() on the error path.

Signed-off-by: Guennadi Liakhovetski <[email protected]>
---
drivers/net/wireless/b43/sdio.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/b43/sdio.c b/drivers/net/wireless/b43/sdio.c
index 9a55338..09e2dfd 100644
--- a/drivers/net/wireless/b43/sdio.c
+++ b/drivers/net/wireless/b43/sdio.c
@@ -163,6 +163,7 @@ static int b43_sdio_probe(struct sdio_func *func,
err_free_ssb:
kfree(sdio);
err_disable_func:
+ sdio_claim_host(func);
sdio_disable_func(func);
err_release_host:
sdio_release_host(func);
--
1.7.2.3

2010-11-23 16:36:29

by Larry Finger

Subject: Re: [PATCH] wireless: b43: fix error path in SDIO

On 11/23/2010 10:10 AM, Guennadi Liakhovetski wrote:
> Fix unbalanced call to sdio_release_host() on the error path.
>
> Signed-off-by: Guennadi Liakhovetski <[email protected]>

>From what I know about SDIO, this patch looks correct. We just fixed a similar
problem in b43_sdio_remove(). Add my ACKed-by.

John,

I think this should be in 2.6.37, and that there should be a Cc for stable.

Larry