2011-03-14 16:53:39

by Ohad Ben Cohen

Subject: [PATCH] wl12xx: update bet_max_consecutive

Allow early termination of 50 consecutive beacons.

This value is the recommended one by the 12xx's system/RF team,
and tests show that power consumption is improved as expected.

Reported-by: Ruthy Zaphir <[email protected]>
Tested-by: Danil Shalumov <[email protected]>
Signed-off-by: Ohad Ben-Cohen <[email protected]>
---
drivers/net/wireless/wl12xx/main.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
index 8b3c8d1..4e6660d 100644
--- a/drivers/net/wireless/wl12xx/main.c
+++ b/drivers/net/wireless/wl12xx/main.c
@@ -254,7 +254,7 @@ static struct conf_drv_settings default_conf = {
.ps_poll_threshold = 10,
.ps_poll_recovery_period = 700,
.bet_enable = CONF_BET_MODE_ENABLE,
- .bet_max_consecutive = 10,
+ .bet_max_consecutive = 50,
.psm_entry_retries = 5,
.psm_exit_retries = 255,
.psm_entry_nullfunc_retries = 3,
--
1.7.1

2011-03-14 16:56:32

by Ohad Ben Cohen

Subject: Re: [PATCH] wl12xx: update bet_max_consecutive

On Mon, Mar 14, 2011 at 6:53 PM, Ohad Ben-Cohen <[email protected]> wrote:
> Allow early termination of 50 consecutive beacons.
>
> This value is the recommended one by the 12xx's system/RF team,
> and tests show that power consumption is improved as expected.
>
> Reported-by: Ruthy Zaphir <[email protected]>
> Tested-by: Danil Shalumov <[email protected]>
> Signed-off-by: Ohad Ben-Cohen <[email protected]>
> ---

- Luciano Coelho <[email protected]>
+ Luciano Coelho <[email protected]>

Sorry, my scripts are outdated.


> ?drivers/net/wireless/wl12xx/main.c | ? ?2 +-
> ?1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/wl12xx/main.c b/drivers/net/wireless/wl12xx/main.c
> index 8b3c8d1..4e6660d 100644
> --- a/drivers/net/wireless/wl12xx/main.c
> +++ b/drivers/net/wireless/wl12xx/main.c
> @@ -254,7 +254,7 @@ static struct conf_drv_settings default_conf = {
> ? ? ? ? ? ? ? ?.ps_poll_threshold ? ? ? ? ? = 10,
> ? ? ? ? ? ? ? ?.ps_poll_recovery_period ? ? = 700,
> ? ? ? ? ? ? ? ?.bet_enable ? ? ? ? ? ? ? ? ?= CONF_BET_MODE_ENABLE,
> - ? ? ? ? ? ? ? .bet_max_consecutive ? ? ? ? = 10,
> + ? ? ? ? ? ? ? .bet_max_consecutive ? ? ? ? = 50,
> ? ? ? ? ? ? ? ?.psm_entry_retries ? ? ? ? ? = 5,
> ? ? ? ? ? ? ? ?.psm_exit_retries ? ? ? ? ? ?= 255,
> ? ? ? ? ? ? ? ?.psm_entry_nullfunc_retries ?= 3,
> --
> 1.7.1
>
>

2011-03-21 13:36:09

by Luciano Coelho

Subject: Re: [PATCH] wl12xx: update bet_max_consecutive

On Mon, 2011-03-14 at 18:53 +0200, Ohad Ben-Cohen wrote:
> Allow early termination of 50 consecutive beacons.
>
> This value is the recommended one by the 12xx's system/RF team,
> and tests show that power consumption is improved as expected.
>
> Reported-by: Ruthy Zaphir <[email protected]>
> Tested-by: Danil Shalumov <[email protected]>
> Signed-off-by: Ohad Ben-Cohen <[email protected]>
> ---

Applied, thank you!

--
Cheers,
Luca.