2011-05-25 00:41:27

by Mike McCormack

Subject: [PATCH 8/8] rtlwifi: Fix logic in rx_interrupt

Should pass along packet if there's no CRC and no hardware error.

Signed-off-by: Mike McCormack <[email protected]>
Signed-off-by: Larry Finger <[email protected]>
---
drivers/net/wireless/rtlwifi/pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 4fe405a..215abfa 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -691,7 +691,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
hdr = rtl_get_hdr(skb);
fc = rtl_get_fc(skb);

- if (!stats.crc || !stats.hwerror) {
+ if (!stats.crc && !stats.hwerror) {
memcpy(IEEE80211_SKB_RXCB(skb), &rx_status,
sizeof(rx_status));

--
1.7.4.1

2011-05-23 19:57:55

by Larry Finger

Subject: Re: [PATCH 8/8] rtlwifi: Fix logic in rx_interrupt

On 05/23/2011 08:55 AM, Mike McCormack wrote:
> Should pass along packet if there's no CRC and no hardware error.
>
> Signed-off-by: Mike McCormack<[email protected]>
> ---
> drivers/net/wireless/rtlwifi/pci.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index 4fe405a..215abfa 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -691,7 +691,7 @@ static void _rtl_pci_rx_interrupt(struct ieee80211_hw *hw)
> hdr = rtl_get_hdr(skb);
> fc = rtl_get_fc(skb);
>
> - if (!stats.crc || !stats.hwerror) {
> + if (!stats.crc&& !stats.hwerror) {
> memcpy(IEEE80211_SKB_RXCB(skb),&rx_status,
> sizeof(rx_status));
>

Good catch.

Signed-off-by: Larry Finger <[email protected]>
---

Larry