2011-06-14 15:43:30

by Mohammed Shafi Shajakhan

Subject: [RFC] ath9k: remove a redundant call to pcipowersave

From: Mohammed Shafi Shajakhan <[email protected]>

during suspend/resume ath9k_stop will always call ath_radio_disable
which will inturn call ath9k_hw_configpcipowersave, so need to call
it explicitly in ath9k_stop

Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
---
drivers/net/wireless/ath/ath9k/main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 7f94533..e7f8ef2 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1259,7 +1259,6 @@ static void ath9k_stop(struct ieee80211_hw *hw)

/* disable HAL and put h/w to sleep */
ath9k_hw_disable(ah);
- ath9k_hw_configpcipowersave(ah, 1, 1);

spin_unlock_bh(&sc->sc_pcu_lock);

--
1.7.0.4

2011-06-15 04:58:40

by Mohammed Shafi Shajakhan

Subject: RE: [RFC] ath9k: remove a redundant call to pcipowersave

________________________________________
From: Mohammed Shafi Shajakhan [[email protected]]
Sent: 14 June 2011 21:12:59
To: [email protected]
Cc: Rodriguez, Luis; Shajakhan, Mohammed
Subject: [RFC] ath9k: remove a redundant call to pcipowersave

From: Mohammed Shafi Shajakhan <[email protected]>

during suspend/resume ath9k_stop will always call ath_radio_disable
which will inturn call ath9k_hw_configpcipowersave, so need to call

mistake "so no need to call"

it explicitly in ath9k_stop

Signed-off-by: Mohammed Shafi Shajakhan <[email protected]>
---
drivers/net/wireless/ath/ath9k/main.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 7f94533..e7f8ef2 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c
@@ -1259,7 +1259,6 @@ static void ath9k_stop(struct ieee80211_hw *hw)

/* disable HAL and put h/w to sleep */
ath9k_hw_disable(ah);
- ath9k_hw_configpcipowersave(ah, 1, 1);

spin_unlock_bh(&sc->sc_pcu_lock);

--
1.7.0.4