2012-02-13 06:20:24

by Sujith Manoharan

Subject: [PATCH 1/7] ath9k: Remove redundant max_streams assignment

Signed-off-by: Sujith Manoharan <[email protected]>
---
drivers/net/wireless/ath/ath9k/init.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
index 53a005d..a625c9a 100644
--- a/drivers/net/wireless/ath/ath9k/init.c
+++ b/drivers/net/wireless/ath/ath9k/init.c
@@ -258,8 +258,6 @@ static void setup_ht_cap(struct ath_softc *sc,

if (AR_SREV_9330(ah) || AR_SREV_9485(ah))
max_streams = 1;
- else if (AR_SREV_9462(ah))
- max_streams = 2;
else if (AR_SREV_9300_20_OR_LATER(ah))
max_streams = 3;
else
--
1.7.9

2012-02-13 13:07:28

by Sujith Manoharan

Subject: Re: [PATCH 1/7] ath9k: Remove redundant max_streams assignment

Felix Fietkau wrote:
> I think AR9462 is also matched by AR_SREV_9300_20_OR_LATER(ah), so that
> one may not be redundant.

Ah, nice catch.

John, can you please drop this patch ?

Sujith

2012-02-13 11:25:02

by Felix Fietkau

Subject: Re: [PATCH 1/7] ath9k: Remove redundant max_streams assignment

On 2012-02-13 7:20 AM, Sujith Manoharan wrote:
> Signed-off-by: Sujith Manoharan <[email protected]>
> ---
> drivers/net/wireless/ath/ath9k/init.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/ath9k/init.c b/drivers/net/wireless/ath/ath9k/init.c
> index 53a005d..a625c9a 100644
> --- a/drivers/net/wireless/ath/ath9k/init.c
> +++ b/drivers/net/wireless/ath/ath9k/init.c
> @@ -258,8 +258,6 @@ static void setup_ht_cap(struct ath_softc *sc,
>
> if (AR_SREV_9330(ah) || AR_SREV_9485(ah))
> max_streams = 1;
> - else if (AR_SREV_9462(ah))
> - max_streams = 2;
> else if (AR_SREV_9300_20_OR_LATER(ah))
> max_streams = 3;
> else
I think AR9462 is also matched by AR_SREV_9300_20_OR_LATER(ah), so that
one may not be redundant.

- Felix