2012-04-02 14:34:42

by Forest Bond

[permalink] [raw]

Subject: [PATCH 2/2] rtl8192de: Recognize 92D E-CUT version.

---

From: Forest Bond <[email protected]>

The chip version constant (0xCC33) was taken from version 0001.0105.2011
of the GPL vendor driver. Note that this driver version also ships a
firmware update, but I am unsure if it is required for E-CUT chips to
function properly.

A nearby spelling error was also corrected.

Signed-off-by: Forest Bond <[email protected]>
---
drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)

diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
index 509f5af..b338d52 100644
--- a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
@@ -1743,9 +1743,13 @@ static void _rtl92de_efuse_update_chip_version(struct ieee80211_hw *hw)
chipver |= CHIP_92D_D_CUT;
RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "D-CUT!!!\n");
break;
+ case 0xCC33:
+ chipver |= CHIP_92D_E_CUT;
+ RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "E-CUT!!!\n");
+ break;
default:
chipver |= CHIP_92D_D_CUT;
- RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG, "Unkown CUT!\n");
+ RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG, "Unknown CUT!\n");
break;
}
rtlpriv->rtlhal.version = chipver;
--
1.7.0.4

---

Attachments:

(No filename) (1.23 kB)
signature.asc (198.00 B)
Digital signature Download all attachments

2012-04-02 16:09:47

by Larry Finger

[permalink] [raw]

Subject: Re: [PATCH 2/2] rtl8192de: Recognize 92D E-CUT version.

---

On 04/02/2012 09:25 AM, Forest Bond wrote:
> From: Forest Bond<[email protected]>
>
> The chip version constant (0xCC33) was taken from version 0001.0105.2011
> of the GPL vendor driver. Note that this driver version also ships a
> firmware update, but I am unsure if it is required for E-CUT chips to
> function properly.

There is also a new version of the RTL8192SE firmware in that driver. Too bad
that Realtek doesn't communicate these changes with me, I will test and submit
the updated firmware if the changes make a difference.

>
> A nearby spelling error was also corrected.
>
> Signed-off-by: Forest Bond<[email protected]>
> ---
> drivers/net/wireless/rtlwifi/rtl8192de/hw.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> index 509f5af..b338d52 100644
> --- a/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192de/hw.c
> @@ -1743,9 +1743,13 @@ static void _rtl92de_efuse_update_chip_version(struct ieee80211_hw *hw)
> chipver |= CHIP_92D_D_CUT;
> RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "D-CUT!!!\n");
> break;
> + case 0xCC33:
> + chipver |= CHIP_92D_E_CUT;
> + RT_TRACE(rtlpriv, COMP_INIT, DBG_LOUD, "E-CUT!!!\n");
> + break;

This comment is a note to myself, not a criticism of your patch. These magic
numbers need to be replaced by defined constants.

> default:
> chipver |= CHIP_92D_D_CUT;
> - RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG, "Unkown CUT!\n");
> + RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG, "Unknown CUT!\n");
> break;
> }
> rtlpriv->rtlhal.version = chipver;

Thanks,

Larry