2012-05-14 20:13:16

by Randy Dunlap

[permalink] [raw]
Subject: [PATCH -next] nfc: shdlc needs to select CRC_CCITT

From: Randy Dunlap <[email protected]>

Fix build error: SHDLC uses crc_ccitt so it should select CRC_CCITT.

ERROR: "crc_ccitt" [net/nfc/hci/hci.ko] undefined!

Signed-off-by: Randy Dunlap <[email protected]>
Cc: Lauro Ramos Venancio <[email protected]>
Cc: Aloisio Almeida Jr <[email protected]>
Cc: Samuel Ortiz <[email protected]>
---
net/nfc/hci/Kconfig | 1 +
1 file changed, 1 insertion(+)

--- linux-next-20120514.orig/net/nfc/hci/Kconfig
+++ linux-next-20120514/net/nfc/hci/Kconfig
@@ -11,6 +11,7 @@ config NFC_SHDLC
depends on NFC_HCI
bool "SHDLC link layer for HCI based NFC drivers"
default n
+ select CRC_CCITT
---help---
Say yes if you use an NFC HCI driver that requires SHDLC link layer.
If unsure, say N here.


2012-05-14 20:23:13

by Samuel Ortiz

[permalink] [raw]
Subject: Re: [PATCH -next] nfc: shdlc needs to select CRC_CCITT

Hi Randy,

On Mon, May 14, 2012 at 01:13:25PM -0700, Randy Dunlap wrote:
> From: Randy Dunlap <[email protected]>
>
> Fix build error: SHDLC uses crc_ccitt so it should select CRC_CCITT.
>
> ERROR: "crc_ccitt" [net/nfc/hci/hci.ko] undefined!
A similar patch was sent a few days ago by Marcel Holtmann.
It is queued to my nfc-fixes branch and I included it to a pull request I sent
to John last week.

Cheers,
Samuel.

--
Intel Open Source Technology Centre
http://oss.intel.com/