2013-03-05 13:20:21

by Felix Fietkau

[permalink] [raw]
Subject: [PATCH] mac80211/minstrel_ht: disable multiple consecutive sample attempts

The last minstrel_ht changes increased the sampling frequency for
potentially useful rates to decrease the response time to rate
fluctuations. This caused an increase in sampling frequency that can
slightly reduce throughput, so this patch limits the sampling attempts
to one per rate instead of two.

Signed-off-by: Felix Fietkau <[email protected]>
---
net/mac80211/rc80211_minstrel_ht.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mac80211/rc80211_minstrel_ht.c b/net/mac80211/rc80211_minstrel_ht.c
index da4ec73..aa59539 100644
--- a/net/mac80211/rc80211_minstrel_ht.c
+++ b/net/mac80211/rc80211_minstrel_ht.c
@@ -480,7 +480,7 @@ minstrel_ht_tx_status(void *priv, struct ieee80211_supported_band *sband,

if (!mi->sample_wait && !mi->sample_tries && mi->sample_count > 0) {
mi->sample_wait = 16 + 2 * MINSTREL_TRUNC(mi->avg_ampdu_len);
- mi->sample_tries = 2;
+ mi->sample_tries = 1;
mi->sample_count--;
}

--
1.8.0.2



2013-03-05 18:49:08

by Johannes Berg

[permalink] [raw]
Subject: Re: [PATCH] mac80211/minstrel_ht: disable multiple consecutive sample attempts

On Tue, 2013-03-05 at 14:20 +0100, Felix Fietkau wrote:
> The last minstrel_ht changes increased the sampling frequency for
> potentially useful rates to decrease the response time to rate
> fluctuations. This caused an increase in sampling frequency that can
> slightly reduce throughput, so this patch limits the sampling attempts
> to one per rate instead of two.

Applied.

johannes