2013-07-23 05:43:34

by Tomasz Moń

Subject: [PATCH] mwifiex: Add missing endian conversion.

Both type and pkt_len variables are in host endian and these should be in
Little Endian in the payload.

Signed-off-by: Tomasz Moń <[email protected]>
Acked-by: Bing Zhao <[email protected]>
---
drivers/net/wireless/mwifiex/sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mwifiex/sdio.c b/drivers/net/wireless/mwifiex/sdio.c
index 5ee5ed0..c9f3ecf 100644
--- a/drivers/net/wireless/mwifiex/sdio.c
+++ b/drivers/net/wireless/mwifiex/sdio.c
@@ -1625,8 +1625,8 @@ static int mwifiex_sdio_host_to_card(struct mwifiex_adapter *adapter,
/* Allocate buffer and copy payload */
blk_size = MWIFIEX_SDIO_BLOCK_SIZE;
buf_block_len = (pkt_len + blk_size - 1) / blk_size;
- *(u16 *) &payload[0] = (u16) pkt_len;
- *(u16 *) &payload[2] = type;
+ *(__le16 *)&payload[0] = cpu_to_le16((u16)pkt_len);
+ *(__le16 *)&payload[2] = cpu_to_le16(type);

/*
* This is SDIO specific header
--
1.8.3.msysgit.0

2013-07-26 04:37:20

by Bing Zhao

Subject: RE: [PATCH] mwifiex: Add missing endian conversion.

SGkgSm9obiwNCg0KPiBCb3RoIHR5cGUgYW5kIHBrdF9sZW4gdmFyaWFibGVzIGFyZSBpbiBob3N0
IGVuZGlhbiBhbmQgdGhlc2Ugc2hvdWxkIGJlIGluDQo+IExpdHRsZSBFbmRpYW4gaW4gdGhlIHBh
eWxvYWQuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBUb21hc3ogTW/FhCA8ZGVzb3dpbkBnbWFpbC5j
b20+DQo+IEFja2VkLWJ5OiBCaW5nIFpoYW8gPGJ6aGFvQG1hcnZlbGwuY29tPg0KDQpDYzogPHN0
YWJsZUB2Z2VyLmtlcm5lbC5vcmc+DQoNCkNvdWxkIHlvdSBwbGVhc2UgYXBwbHkgdGhpcyBwYXRj
aCB0byB3aXJlbGVzcy5naXQgZm9yIDMuMTE/DQoNClRoYW5rcywNCkJpbmcNCg0KPiAtLS0NCj4g
IGRyaXZlcnMvbmV0L3dpcmVsZXNzL213aWZpZXgvc2Rpby5jIHwgNCArKy0tDQo+ICAxIGZpbGUg
Y2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdp
dCBhL2RyaXZlcnMvbmV0L3dpcmVsZXNzL213aWZpZXgvc2Rpby5jIGIvZHJpdmVycy9uZXQvd2ly
ZWxlc3MvbXdpZmlleC9zZGlvLmMNCj4gaW5kZXggNWVlNWVkMC4uYzlmM2VjZiAxMDA2NDQNCj4g
LS0tIGEvZHJpdmVycy9uZXQvd2lyZWxlc3MvbXdpZmlleC9zZGlvLmMNCj4gKysrIGIvZHJpdmVy
cy9uZXQvd2lyZWxlc3MvbXdpZmlleC9zZGlvLmMNCj4gQEAgLTE2MjUsOCArMTYyNSw4IEBAIHN0
YXRpYyBpbnQgbXdpZmlleF9zZGlvX2hvc3RfdG9fY2FyZChzdHJ1Y3QgbXdpZmlleF9hZGFwdGVy
ICphZGFwdGVyLA0KPiAgCS8qIEFsbG9jYXRlIGJ1ZmZlciBhbmQgY29weSBwYXlsb2FkICovDQo+
ICAJYmxrX3NpemUgPSBNV0lGSUVYX1NESU9fQkxPQ0tfU0laRTsNCj4gIAlidWZfYmxvY2tfbGVu
ID0gKHBrdF9sZW4gKyBibGtfc2l6ZSAtIDEpIC8gYmxrX3NpemU7DQo+IC0JKih1MTYgKikgJnBh
eWxvYWRbMF0gPSAodTE2KSBwa3RfbGVuOw0KPiAtCSoodTE2ICopICZwYXlsb2FkWzJdID0gdHlw
ZTsNCj4gKwkqKF9fbGUxNiAqKSZwYXlsb2FkWzBdID0gY3B1X3RvX2xlMTYoKHUxNilwa3RfbGVu
KTsNCj4gKwkqKF9fbGUxNiAqKSZwYXlsb2FkWzJdID0gY3B1X3RvX2xlMTYodHlwZSk7DQo+IA0K
PiAgCS8qDQo+ICAJICogVGhpcyBpcyBTRElPIHNwZWNpZmljIGhlYWRlcg0KPiAtLQ0KPiAxLjgu
My5tc3lzZ2l0LjANCg0K