2013-10-23 18:55:40

by Luis Chamberlain

[permalink] [raw]
Subject: [RFC] cfg80211: make genregdb.awk skip antenna gain

Now that wireless-regdb doesn't include
antenna gain lets skip parsing it completely
for when CONFIG_CFG80211_INTERNAL_REGDB is
enabled.

Signed-off-by: Luis R. Rodriguez <[email protected]>
---
net/wireless/genregdb.awk | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
mode change 100644 => 100755 net/wireless/genregdb.awk

diff --git a/net/wireless/genregdb.awk b/net/wireless/genregdb.awk
old mode 100644
new mode 100755
index c808619..3e241e4e
--- a/net/wireless/genregdb.awk
+++ b/net/wireless/genregdb.awk
@@ -63,14 +63,11 @@ active && /^[ \t]*\(/ {
end = $3
bw = $5
sub(/\),/, "", bw)
- gain = $6
- sub(/\(/, "", gain)
- sub(/,/, "", gain)
- power = $7
- sub(/\)/, "", power)
+ power = $6
+ sub(/\(/, "", power)
sub(/,/, "", power)
# power might be in mW...
- units = $8
+ units = $7
sub(/\)/, "", units)
sub(/,/, "", units)
if (units == "mW") {
@@ -87,7 +84,7 @@ active && /^[ \t]*\(/ {
}
}
flagstr = ""
- for (i=8; i<=NF; i++)
+ for (i=7; i<=NF; i++)
flagstr = flagstr $i
split(flagstr, flagarray, ",")
flags = ""
--
1.8.4.rc3



2014-03-31 12:53:28

by Jonas Gorski

[permalink] [raw]
Subject: Re: [RFC] cfg80211: make genregdb.awk skip antenna gain

On Wed, Oct 23, 2013 at 8:55 PM, Luis R. Rodriguez
<[email protected]> wrote:
> Now that wireless-regdb doesn't include
> antenna gain lets skip parsing it completely
> for when CONFIG_CFG80211_INTERNAL_REGDB is
> enabled.
>
> Signed-off-by: Luis R. Rodriguez <[email protected]>

As far as I can tell, this is still needed for current regdb.txt's (at
least we needed it in OpenWrt). Assuming it wasn't applied because of
RFC, can you resend it as a "proper" patch? One small question though
...

> ---
> net/wireless/genregdb.awk | 11 ++++-------
> 1 file changed, 4 insertions(+), 7 deletions(-)
> mode change 100644 => 100755 net/wireless/genregdb.awk

was this mode change intentional?

> (snip)


Regards
Jonas