Hello there,
I just ran the static analyser "cppcheck" over the source code of linux-3.12
It said
[linux-3.12/drivers/net/wireless/rtlwifi/rtl8188ee/dm.c:1081] -> [linux-3.12/drivers/net/wireless/rtlwifi/rtl8188ee/dm.c:1081]: (style) Same expression on both sides of '!='.
Source code is
??????????? if (rtldm->swing_idx_cck != rtldm->swing_idx_cck) {
??????????????? rtldm->swing_idx_cck_cur = rtldm->swing_idx_cck;
??????????????? rtldm->swing_flag_cck = true;
??????????? }
Suggest code rework. Maybe something like
??????????? if (rtldm->swing_idx_cck_cur != rtldm->swing_idx_cck) {
??????????????? rtldm->swing_idx_cck_cur = rtldm->swing_idx_cck;
??????????????? rtldm->swing_flag_cck = true;
??????????? }
might be suitable.
Regards
David Binderman