2014-05-02 06:48:26

by Andy Spencer

Subject: [PATCH] RTL8192CU: Increase max APFM_ONMAC polling count

With certain hardware combinations the poll interval is exceeded before
initialization completes.

Tested on a MacBookPro10,1 using a Sabrent USB-A11N USB adapter.

Signed-off-by: Andy Spencer <[email protected]>
---
I was unable to reproduce this issue using other hardware combinations.
I thought it might be a USB3 issue but another laptop with USB3 worked
without the patch.

With my hardware the polling count reaches around 230 before
initialization completes.

drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
+++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
@@ -511,7 +511,7 @@ static int _rtl92cu_init_power_on(struct ieee80211_hw *hw)
pr_info("MAC auto ON okay!\n");
break;
}
- if (pollingCount++ > 100) {
+ if (pollingCount++ > 1000) {
RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
"Failed to polling REG_APS_FSMCO[APFM_ONMAC] done!\n");
return -ENODEV;

2014-05-06 14:18:23

by Larry Finger

Subject: Re: [PATCH] RTL8192CU: Increase max APFM_ONMAC polling count

On 05/02/2014 01:48 AM, Andy Spencer wrote:
> With certain hardware combinations the poll interval is exceeded before
> initialization completes.
>
> Tested on a MacBookPro10,1 using a Sabrent USB-A11N USB adapter.
>
> Signed-off-by: Andy Spencer <[email protected]>
> ---
> I was unable to reproduce this issue using other hardware combinations.
> I thought it might be a USB3 issue but another laptop with USB3 worked
> without the patch.
>
> With my hardware the polling count reaches around 230 before
> initialization completes.

Acked-by: Larry Finger <[email protected]>

If the adapter initializes quickly, this change causes no problem. I have not
seen this kind of problem, but some hardware is obviously different.

Larry

>
> drivers/net/wireless/rtlwifi/rtl8192cu/hw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> +++ b/drivers/net/wireless/rtlwifi/rtl8192cu/hw.c
> @@ -511,7 +511,7 @@ static int _rtl92cu_init_power_on(struct ieee80211_hw *hw)
> pr_info("MAC auto ON okay!\n");
> break;
> }
> - if (pollingCount++ > 100) {
> + if (pollingCount++ > 1000) {
> RT_TRACE(rtlpriv, COMP_INIT, DBG_EMERG,
> "Failed to polling REG_APS_FSMCO[APFM_ONMAC] done!\n");
> return -ENODEV;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>