2014-10-01 14:21:03

by Dan Carpenter

Subject: re: NFC: trf7970a: Handle timeout values of zero

Hello Mark A. Greer,

The patch 1961843ceeca: "NFC: trf7970a: Handle timeout values of
zero" from Sep 2, 2014, leads to the following static checker warning:

drivers/nfc/trf7970a.c:897 trf7970a_irq()
warn: passing zero to 'ERR_PTR'

drivers/nfc/trf7970a.c
892 trf7970a_cmd(trf, TRF7970A_CMD_FIFO_RESET);
893
894 if (!trf->timeout) {
895 trf->ignore_timeout = !cancel_delayed_work(
896 &trf->timeout_work);
897 trf->rx_skb = ERR_PTR(0);
^^^^^^^^^^
Why not just say "NULL"?

898 trf7970a_send_upstream(trf);
899 break;
900 }

regards,
dan carpenter

2014-10-01 16:19:09

by Mark Greer

Subject: Re: NFC: trf7970a: Handle timeout values of zero

On Wed, Oct 01, 2014 at 05:20:48PM +0300, Dan Carpenter wrote:
> Hello Mark A. Greer,
>
> The patch 1961843ceeca: "NFC: trf7970a: Handle timeout values of
> zero" from Sep 2, 2014, leads to the following static checker warning:
>
> drivers/nfc/trf7970a.c:897 trf7970a_irq()
> warn: passing zero to 'ERR_PTR'
>
> drivers/nfc/trf7970a.c
> 892 trf7970a_cmd(trf, TRF7970A_CMD_FIFO_RESET);
> 893
> 894 if (!trf->timeout) {
> 895 trf->ignore_timeout = !cancel_delayed_work(
> 896 &trf->timeout_work);
> 897 trf->rx_skb = ERR_PTR(0);
> ^^^^^^^^^^
> Why not just say "NULL"?

No reason. I thought I'd fixed them all.

Mark
--