2014-10-09 10:00:09

by Dan Carpenter

Subject: [patch 2/2] ipw2x00: clean up a condition

The original condition was "(PAGE_SIZE - len)" when "(len < PAGE_SIZE)"
is intended.

This condition is not really sufficient, but also not really needed...
If "len > PAGE_SIZE" then it we will print a warning message in dmesg
but there are no other effects. Maybe we should just remove the
condition?

Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/drivers/net/wireless/ipw2x00/ipw2200.c b/drivers/net/wireless/ipw2x00/ipw2200.c
index edc3443..67cad9b 100644
--- a/drivers/net/wireless/ipw2x00/ipw2200.c
+++ b/drivers/net/wireless/ipw2x00/ipw2200.c
@@ -1363,7 +1363,7 @@ static ssize_t show_cmd_log(struct device *d,
if (!priv->cmdlog)
return 0;
for (i = (priv->cmdlog_pos + 1) % priv->cmdlog_len;
- (i != priv->cmdlog_pos) && (PAGE_SIZE - len);
+ (i != priv->cmdlog_pos) && (len < PAGE_SIZE);
i = (i + 1) % priv->cmdlog_len) {
len +=
snprintf(buf + len, PAGE_SIZE - len,

2014-10-15 20:52:28

by Stanislav Yakovlev

Subject: Re: [patch 2/2] ipw2x00: clean up a condition

Hello Dan,

On 9 October 2014 02:59, Dan Carpenter <[email protected]> wrote:
> The original condition was "(PAGE_SIZE - len)" when "(len < PAGE_SIZE)"
> is intended.
>
> This condition is not really sufficient, but also not really needed...
> If "len > PAGE_SIZE" then it we will print a warning message in dmesg
> but there are no other effects. Maybe we should just remove the
> condition?
>
> Signed-off-by: Dan Carpenter <[email protected]>

Looks fine, thanks.

Stanislav.