2015-03-09 13:23:13

by Michal Kazior

Subject: [PATCH] ath10k: fix CAC regression

Patch `ath10k: fix interrupt storm` introduced a
regression. The condition responsible for bringing
up monitor vdev was broken and it was never
started for CAC so effectivelly CAC would not
detect radar pulses.

Signed-off-by: Michal Kazior <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 1138f4f..9887e09 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -856,7 +856,7 @@ static int ath10k_monitor_recalc(struct ath10k *ar)
lockdep_assert_held(&ar->conf_mutex);

should_start = ar->monitor ||
- !ath10k_mac_should_disable_promisc(ar);
+ !ath10k_mac_should_disable_promisc(ar) ||
test_bit(ATH10K_CAC_RUNNING, &ar->dev_flags);

ath10k_dbg(ar, ATH10K_DBG_MAC,
--
1.8.5.3

2015-03-12 12:32:30

by Kalle Valo

Subject: Re: [PATCH] ath10k: fix CAC regression

Michal Kazior <[email protected]> writes:

> Patch `ath10k: fix interrupt storm` introduced a
> regression. The condition responsible for bringing
> up monitor vdev was broken and it was never
> started for CAC so effectivelly CAC would not
> detect radar pulses.
>
> Signed-off-by: Michal Kazior <[email protected]>

Thanks, applied. I just added the commit id to the commit log.

--
Kalle Valo