This cleanup was already completed between end 2011 and early 2012
with a patch series from Lars-Peter Clausen:
https://lkml.org/lkml/2011/11/24/190
Later on new redundant initialization re-appeared here and there.
Time to cleanup again.
And, yes, I'm lazy! I copy-paste the exact same commit message from
Lars-Peter; only minor reformat to stay in 75 char/line and fix the
name of spi_register_driver().
Regards,
Antonio
Antonio Borneo (6):
ASoC: wm0010: Remove redundant spi driver bus initialization
iio: ssp_sensors: Remove redundant spi driver bus initialization
staging: mt29f_spinand: Remove redundant spi driver bus initialization
net: ieee802154: Remove redundant spi driver bus initialization
wireless: cw1200: Remove redundant spi driver bus initialization
[media] s5c73m3: Remove redundant spi driver bus initialization
drivers/iio/common/ssp_sensors/ssp_dev.c | 1 -
drivers/media/i2c/s5c73m3/s5c73m3-spi.c | 1 -
drivers/net/ieee802154/cc2520.c | 1 -
drivers/net/ieee802154/mrf24j40.c | 1 -
drivers/net/wireless/cw1200/cw1200_spi.c | 1 -
drivers/staging/mt29f_spinand/mt29f_spinand.c | 1 -
sound/soc/codecs/wm0010.c | 1 -
7 files changed, 7 deletions(-)
--
2.4.4
In ancient times it was necessary to manually initialize the bus
field of an spi_driver to spi_bus_type. These days this is done in
spi_register_driver(), so we can drop the manual assignment.
Signed-off-by: Antonio Borneo <[email protected]>
To: Solomon Peachy <[email protected]>
To: Kalle Valo <[email protected]>
To: [email protected]
To: [email protected]
Cc: [email protected]
---
drivers/net/wireless/cw1200/cw1200_spi.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/cw1200/cw1200_spi.c b/drivers/net/wireless/cw1200/cw1200_spi.c
index 7603546..29185ae 100644
--- a/drivers/net/wireless/cw1200/cw1200_spi.c
+++ b/drivers/net/wireless/cw1200/cw1200_spi.c
@@ -467,7 +467,6 @@ static struct spi_driver spi_driver = {
.remove = cw1200_spi_disconnect,
.driver = {
.name = "cw1200_wlan_spi",
- .bus = &spi_bus_type,
.owner = THIS_MODULE,
#ifdef CONFIG_PM
.pm = &cw1200_pm_ops,
--
2.4.4
> In ancient times it was necessary to manually initialize the bus
> field of an spi_driver to spi_bus_type. These days this is done in
> spi_register_driver(), so we can drop the manual assignment.
>
> Signed-off-by: Antonio Borneo <[email protected]>
> To: Solomon Peachy <[email protected]>
> To: Kalle Valo <[email protected]>
> To: [email protected]
> To: [email protected]
> Cc: [email protected]
Thanks, applied to wireless-drivers-next.git.
Kalle Valo