2015-06-30 00:50:35

by Nikolas Nyby

[permalink] [raw]

Subject: [PATCH] b43: Fix typo in function name

---

This fixes a typo in the "b43_lo_g_maintenance_work" function
name.

Signed-off-by: Nik Nyby <[email protected]>
---
drivers/net/wireless/b43/lo.c | 4 ++--
drivers/net/wireless/b43/lo.h | 2 +-
drivers/net/wireless/b43/phy_g.c | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/wireless/b43/lo.c b/drivers/net/wireless/b43/lo.c
index 916123a..a335f94 100644
--- a/drivers/net/wireless/b43/lo.c
+++ b/drivers/net/wireless/b43/lo.c
@@ -929,8 +929,8 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
b43_lo_write(dev, &cal->ctl);
}

-/* Periodic LO maintanance work */
-void b43_lo_g_maintanance_work(struct b43_wldev *dev)
+/* Periodic LO maintenance work */
+void b43_lo_g_maintenance_work(struct b43_wldev *dev)
{
struct b43_phy *phy = &dev->phy;
struct b43_phy_g *gphy = phy->g;
diff --git a/drivers/net/wireless/b43/lo.h b/drivers/net/wireless/b43/lo.h
index 3b27e20..7b4df38 100644
--- a/drivers/net/wireless/b43/lo.h
+++ b/drivers/net/wireless/b43/lo.h
@@ -80,7 +80,7 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,

void b43_gphy_dc_lt_init(struct b43_wldev *dev, bool update_all);

-void b43_lo_g_maintanance_work(struct b43_wldev *dev);
+void b43_lo_g_maintenance_work(struct b43_wldev *dev);
void b43_lo_g_cleanup(struct b43_wldev *dev);
void b43_lo_g_init(struct b43_wldev *dev);

diff --git a/drivers/net/wireless/b43/phy_g.c b/drivers/net/wireless/b43/phy_g.c
index 727ce6e..462310e 100644
--- a/drivers/net/wireless/b43/phy_g.c
+++ b/drivers/net/wireless/b43/phy_g.c
@@ -3004,7 +3004,7 @@ static void b43_gphy_op_pwork_15sec(struct b43_wldev *dev)
phy->rev == 1) {
//TODO: implement rev1 workaround
}
- b43_lo_g_maintanance_work(dev);
+ b43_lo_g_maintenance_work(dev);
b43_mac_enable(dev);
}

--
2.1.4

2015-06-30 15:16:42

by Michael Büsch

[permalink] [raw]

Subject: Re: [PATCH] b43: Fix typo in function name

---

On Mon, 29 Jun 2015 20:29:24 -0500
Larry Finger <[email protected]> wrote:

> On 06/29/2015 07:45 PM, Nik Nyby wrote:
> > This fixes a typo in the "b43_lo_g_maintenance_work" function
> > name.
> >
> > Signed-off-by: Nik Nyby <[email protected]>
> > ---
> > drivers/net/wireless/b43/lo.c | 4 ++--
> > drivers/net/wireless/b43/lo.h | 2 +-
> > drivers/net/wireless/b43/phy_g.c | 2 +-
> > 3 files changed, 4 insertions(+), 4 deletions(-)
>
> This patch is OK; however, can there really be a typo in a function name? How do
> you ever know that the author did not mean to use a name that looks like a typo?
>
> Please be careful with these.
>
> Acked-by: Larry Finger <[email protected]>


Nice finding.
Me as the original author of that mess gets a brown paper bag and acks
this.

Acked-by: Michael Buesch <[email protected]>


--
Michael

---

Attachments:

(No filename) (819.00 B)
OpenPGP digital signature

2015-06-30 01:29:28

by Larry Finger

[permalink] [raw]

Subject: Re: [PATCH] b43: Fix typo in function name

---

On 06/29/2015 07:45 PM, Nik Nyby wrote:
> This fixes a typo in the "b43_lo_g_maintenance_work" function
> name.
>
> Signed-off-by: Nik Nyby <[email protected]>
> ---
> drivers/net/wireless/b43/lo.c | 4 ++--
> drivers/net/wireless/b43/lo.h | 2 +-
> drivers/net/wireless/b43/phy_g.c | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)

This patch is OK; however, can there really be a typo in a function name? How do
you ever know that the author did not mean to use a name that looks like a typo?

Please be careful with these.

Acked-by: Larry Finger <[email protected]>

Larry

>
> diff --git a/drivers/net/wireless/b43/lo.c b/drivers/net/wireless/b43/lo.c
> index 916123a..a335f94 100644
> --- a/drivers/net/wireless/b43/lo.c
> +++ b/drivers/net/wireless/b43/lo.c
> @@ -929,8 +929,8 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
> b43_lo_write(dev, &cal->ctl);
> }
>
> -/* Periodic LO maintanance work */
> -void b43_lo_g_maintanance_work(struct b43_wldev *dev)
> +/* Periodic LO maintenance work */
> +void b43_lo_g_maintenance_work(struct b43_wldev *dev)
> {
> struct b43_phy *phy = &dev->phy;
> struct b43_phy_g *gphy = phy->g;
> diff --git a/drivers/net/wireless/b43/lo.h b/drivers/net/wireless/b43/lo.h
> index 3b27e20..7b4df38 100644
> --- a/drivers/net/wireless/b43/lo.h
> +++ b/drivers/net/wireless/b43/lo.h
> @@ -80,7 +80,7 @@ void b43_lo_g_adjust_to(struct b43_wldev *dev,
>
> void b43_gphy_dc_lt_init(struct b43_wldev *dev, bool update_all);
>
> -void b43_lo_g_maintanance_work(struct b43_wldev *dev);
> +void b43_lo_g_maintenance_work(struct b43_wldev *dev);
> void b43_lo_g_cleanup(struct b43_wldev *dev);
> void b43_lo_g_init(struct b43_wldev *dev);
>
> diff --git a/drivers/net/wireless/b43/phy_g.c b/drivers/net/wireless/b43/phy_g.c
> index 727ce6e..462310e 100644
> --- a/drivers/net/wireless/b43/phy_g.c
> +++ b/drivers/net/wireless/b43/phy_g.c
> @@ -3004,7 +3004,7 @@ static void b43_gphy_op_pwork_15sec(struct b43_wldev *dev)
> phy->rev == 1) {
> //TODO: implement rev1 workaround
> }
> - b43_lo_g_maintanance_work(dev);
> + b43_lo_g_maintenance_work(dev);
> b43_mac_enable(dev);
> }
>
>

2015-07-21 13:53:22

by Kalle Valo

[permalink] [raw]

Subject: Re: b43: Fix typo in function name

---

> This fixes a typo in the "b43_lo_g_maintenance_work" function
> name.
>
> Signed-off-by: Nik Nyby <[email protected]>
> Acked-by: Larry Finger <[email protected]>
> Acked-by: Michael Buesch <[email protected]>

Thanks, applied to wireless-drivers-next.git.

Kalle Valo