2016-01-30 14:39:19

by Dan Carpenter

Subject: [patch] mac80211: free sinfo on error path

There is a missing kfree(sinfo) on error in sta_info_insert_finish().

Fixes: 5fe74014172d ('mac80211: avoid excessive stack usage in sta_info')
Signed-off-by: Dan Carpenter <[email protected]>

diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index 6c198e6..1502efb 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -562,6 +562,7 @@ static int sta_info_insert_finish(struct sta_info *sta) __acquires(RCU)
out_err:
mutex_unlock(&local->sta_mtx);
rcu_read_lock();
+ kfree(sinfo);
return err;
}

2016-01-30 19:58:40

by Arend Van Spriel

Subject: Re: [patch] mac80211: free sinfo on error path

On 30-01-16 15:39, Dan Carpenter wrote:
> There is a missing kfree(sinfo) on error in sta_info_insert_finish().
>
> Fixes: 5fe74014172d ('mac80211: avoid excessive stack usage in sta_info')
> Signed-off-by: Dan Carpenter <[email protected]>

Hi Dan,

A fix for this has already been posted [1]. Although your 'Fixes:' tag
is useful to have, I guess.

Regards,
Arend

[1]
http://mid.gmane.org/[email protected]

> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index 6c198e6..1502efb 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -562,6 +562,7 @@ static int sta_info_insert_finish(struct sta_info *sta) __acquires(RCU)
> out_err:
> mutex_unlock(&local->sta_mtx);
> rcu_read_lock();
> + kfree(sinfo);
> return err;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>