2017-05-09 13:15:03

by Gustavo A. R. Silva

Subject: [PATCH v2] ath10k: remove unnecessary code

The array fields in struct wmi_start_scan_arg that are checked here are
fixed size arrays so they can never be NULL.

Addresses-Coverity-ID: 1260031
Cc: Arend Van Spriel <[email protected]>
Cc: Kalle Valo <[email protected]>
Signed-off-by: Gustavo A. R. Silva <[email protected]>
---
Changes in v2:
Rephrase commit log.

drivers/net/wireless/ath/ath10k/wmi.c | 9 ---------
1 file changed, 9 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c
index 2f1743e..135cf83 100644
--- a/drivers/net/wireless/ath/ath10k/wmi.c
+++ b/drivers/net/wireless/ath/ath10k/wmi.c
@@ -5933,15 +5933,6 @@ static struct sk_buff *ath10k_wmi_10_4_op_gen_init(struct ath10k *ar)

int ath10k_wmi_start_scan_verify(const struct wmi_start_scan_arg *arg)
{
- if (arg->ie_len && !arg->ie)
- return -EINVAL;
- if (arg->n_channels && !arg->channels)
- return -EINVAL;
- if (arg->n_ssids && !arg->ssids)
- return -EINVAL;
- if (arg->n_bssids && !arg->bssids)
- return -EINVAL;
-
if (arg->ie_len > WLAN_SCAN_PARAMS_MAX_IE_LEN)
return -EINVAL;
if (arg->n_channels > ARRAY_SIZE(arg->channels))
--
2.5.0

2017-05-23 15:25:50

by Kalle Valo

Subject: Re: [v2] ath10k: remove unnecessary code

"Gustavo A. R. Silva" <[email protected]> wrote:
> The array fields in struct wmi_start_scan_arg that are checked here are
> fixed size arrays so they can never be NULL.
>
> Addresses-Coverity-ID: 1260031
> Cc: Arend Van Spriel <[email protected]>
> Cc: Kalle Valo <[email protected]>
> Signed-off-by: Gustavo A. R. Silva <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

8c1f20815231 ath10k: remove unnecessary code

--
https://patchwork.kernel.org/patch/9717869/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches