2017-08-03 14:30:41

by Amitkumar Karwar

Subject: [PATCH] rsi: fix uninitialized descriptor pointer issue

From: Prameela Rani Garnepudi <[email protected]>

This patch fixes the uninitialized descriptor pointer
issue in function rsi_send_internal_mgmt_frame().
Descriptor should point to start of the skb data.

Reported-by: Dan Carpenter <[email protected]>
Fixes: 9a629fafe7d8 ("rsi: immediate wakeup bit and priority for TX command packets")
Signed-off-by: Prameela Rani Garnepudi <[email protected]>
Signed-off-by: Amitkumar Karwar <[email protected]>
---
drivers/net/wireless/rsi/rsi_91x_mgmt.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/rsi/rsi_91x_mgmt.c b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
index c6e8a20..ba8a68f 100644
--- a/drivers/net/wireless/rsi/rsi_91x_mgmt.c
+++ b/drivers/net/wireless/rsi/rsi_91x_mgmt.c
@@ -275,6 +275,7 @@ static int rsi_send_internal_mgmt_frame(struct rsi_common *common,
rsi_dbg(ERR_ZONE, "%s: Unable to allocate skb\n", __func__);
return -ENOMEM;
}
+ desc = (struct rsi_cmd_desc *)skb->data;
desc->desc_dword0.len_qno |= cpu_to_le16(DESC_IMMEDIATE_WAKEUP);
skb->priority = MGMT_SOFT_Q;
tx_params = (struct skb_info *)&IEEE80211_SKB_CB(skb)->driver_data;
--
2.7.4

2017-08-08 11:45:40

by Kalle Valo

Subject: Re: rsi: fix uninitialized descriptor pointer issue

Amitkumar Karwar <[email protected]> wrote:

> From: Prameela Rani Garnepudi <[email protected]>
>
> This patch fixes the uninitialized descriptor pointer
> issue in function rsi_send_internal_mgmt_frame().
> Descriptor should point to start of the skb data.
>
> Reported-by: Dan Carpenter <[email protected]>
> Fixes: 9a629fafe7d8 ("rsi: immediate wakeup bit and priority for TX command packets")
> Signed-off-by: Prameela Rani Garnepudi <[email protected]>
> Signed-off-by: Amitkumar Karwar <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

6345016d4bea rsi: fix uninitialized descriptor pointer issue

--
https://patchwork.kernel.org/patch/9879245/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches