2017-12-11 22:37:50

by Jonathan Corbet

Subject: nl80211: Remove obsolete kerneldoc line

Commit ca986ad9bcd3 (nl80211: allow multiple active scheduled scan
requests) removed WIPHY_FLAG_SUPPORTS_SCHED_SCAN but left the kerneldoc
description in place, leading to this docs-build warning:

./include/net/cfg80211.h:3278: warning: Excess enum value
'WIPHY_FLAG_SUPPORTS_SCHED_SCAN' description in 'wiphy_flags'

Remove the line and gain a bit of peace.

Signed-off-by: Jonathan Corbet <[email protected]>
---
include/net/cfg80211.h | 1 -
1 file changed, 1 deletion(-)

diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
index 8b8118a7fadb..cb4d92b79cd9 100644
--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h
@@ -3226,7 +3226,6 @@ struct cfg80211_ops {
* @WIPHY_FLAG_IBSS_RSN: The device supports IBSS RSN.
* @WIPHY_FLAG_MESH_AUTH: The device supports mesh authentication by routing
* auth frames to userspace. See @NL80211_MESH_SETUP_USERSPACE_AUTH.
- * @WIPHY_FLAG_SUPPORTS_SCHED_SCAN: The device supports scheduled scans.
* @WIPHY_FLAG_SUPPORTS_FW_ROAM: The device supports roaming feature in the
* firmware.
* @WIPHY_FLAG_AP_UAPSD: The device supports uapsd on AP.
--
2.14.3

2017-12-12 11:15:51

by Arend Van Spriel

Subject: Re: nl80211: Remove obsolete kerneldoc line

On Mon, Dec 11, 2017 at 11:37 PM, Jonathan Corbet <[email protected]> wrote:
> Commit ca986ad9bcd3 (nl80211: allow multiple active scheduled scan
> requests) removed WIPHY_FLAG_SUPPORTS_SCHED_SCAN but left the kerneldoc
> description in place, leading to this docs-build warning:
>
> ./include/net/cfg80211.h:3278: warning: Excess enum value
> 'WIPHY_FLAG_SUPPORTS_SCHED_SCAN' description in 'wiphy_flags'
>
> Remove the line and gain a bit of peace.

My bad. Thanks for cleaning up.

Acked-by: Arend van Spriel <[email protected]>
> Signed-off-by: Jonathan Corbet <[email protected]>
> ---
> include/net/cfg80211.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/net/cfg80211.h b/include/net/cfg80211.h
> index 8b8118a7fadb..cb4d92b79cd9 100644
> --- a/include/net/cfg80211.h
> +++ b/include/net/cfg80211.h
> @@ -3226,7 +3226,6 @@ struct cfg80211_ops {
> * @WIPHY_FLAG_IBSS_RSN: The device supports IBSS RSN.
> * @WIPHY_FLAG_MESH_AUTH: The device supports mesh authentication by routing
> * auth frames to userspace. See @NL80211_MESH_SETUP_USERSPACE_AUTH.
> - * @WIPHY_FLAG_SUPPORTS_SCHED_SCAN: The device supports scheduled scans.
> * @WIPHY_FLAG_SUPPORTS_FW_ROAM: The device supports roaming feature in the
> * firmware.
> * @WIPHY_FLAG_AP_UAPSD: The device supports uapsd on AP.
> --
> 2.14.3
>