Hi Luca,
I hope I catched the correct MLs (not sure if linux-firmware has a ML,
I did not found any in the MAINTAINERS file).
I have seen that in the WHENCE file there is "Version" with and
without ":", mostly iwlwifi ucodes.
As an example:
File: iwlwifi-8265-36.ucode
-Version 36.e91976c0.0
+Version: 36.e91976c0.0
I don't know the workflow: Do you want to fix it in your tree or
directly in linux-firmware.git upstream?
My attached patch is against upstream.
Thanks.
Regards,
- Sedat -
[1] https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware.git/commit/?id=1f4dbd8cb94ec37497e58627a127058d53c5968f
On Mon, 2018-05-07 at 09:47 +0200, Sedat Dilek wrote:
> On Sun, May 6, 2018 at 3:07 PM, Luciano Coelho <luciano.coelho@intel.
> com> wrote:
> > On Sun, 2018-05-06 at 14:46 +0200, Sedat Dilek wrote:
> > > Hi Luca,
> > >
> > > I hope I catched the correct MLs (not sure if linux-firmware has
> > > a
> > > ML,
> > > I did not found any in the MAINTAINERS file).
> > >
> > > I have seen that in the WHENCE file there is "Version" with and
> > > without ":", mostly iwlwifi ucodes.
> > >
> > > As an example:
> > >
> > > File: iwlwifi-8265-36.ucode
> > > -Version 36.e91976c0.0
> > > +Version: 36.e91976c0.0
> > >
> > > I don't know the workflow: Do you want to fix it in your tree or
> > > directly in linux-firmware.git upstream?
> > > My attached patch is against upstream.
> >
> > Thanks, Sedat!
> >
> > I'm going to send a new pull-request this week, so I can include
> > your
> > patch in my tree and as part of the pull-request.
> >
> > --
> > Cheers,
> > Luca.
>
> OK, Thanks.
> Attached Patch v2 is against your tree [1].
> It differs from v1 against upstream.
You need to write a proper commit message and sign it off so I can
apply it.
--
Luca.
On Sun, May 6, 2018 at 3:07 PM, Luciano Coelho <[email protected]> wrote:
> On Sun, 2018-05-06 at 14:46 +0200, Sedat Dilek wrote:
>> Hi Luca,
>>
>> I hope I catched the correct MLs (not sure if linux-firmware has a
>> ML,
>> I did not found any in the MAINTAINERS file).
>>
>> I have seen that in the WHENCE file there is "Version" with and
>> without ":", mostly iwlwifi ucodes.
>>
>> As an example:
>>
>> File: iwlwifi-8265-36.ucode
>> -Version 36.e91976c0.0
>> +Version: 36.e91976c0.0
>>
>> I don't know the workflow: Do you want to fix it in your tree or
>> directly in linux-firmware.git upstream?
>> My attached patch is against upstream.
>
> Thanks, Sedat!
>
> I'm going to send a new pull-request this week, so I can include your
> patch in my tree and as part of the pull-request.
>
> --
> Cheers,
> Luca.
OK, Thanks.
Attached Patch v2 is against your tree [1].
It differs from v1 against upstream.
- Sedat -
[1] https://git.kernel.org/pub/scm/linux/kernel/git/iwlwifi/linux-firmware.git/
On Sun, 2018-05-06 at 14:46 +0200, Sedat Dilek wrote:
> Hi Luca,
>
> I hope I catched the correct MLs (not sure if linux-firmware has a
> ML,
> I did not found any in the MAINTAINERS file).
>
> I have seen that in the WHENCE file there is "Version" with and
> without ":", mostly iwlwifi ucodes.
>
> As an example:
>
> File: iwlwifi-8265-36.ucode
> -Version 36.e91976c0.0
> +Version: 36.e91976c0.0
>
> I don't know the workflow: Do you want to fix it in your tree or
> directly in linux-firmware.git upstream?
> My attached patch is against upstream.
Thanks, Sedat!
I'm going to send a new pull-request this week, so I can include your
patch in my tree and as part of the pull-request.
--
Cheers,
Luca.