2018-06-13 06:48:12

by Govind Singh

Subject: [PATCH] ath10k: Handle resource init failure case

Return type of resource init method is not assigned.
Handle resource init failures for graceful exit.

Signed-off-by: Govind Singh <[email protected]>
---
drivers/net/wireless/ath/ath10k/snoc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath10k/snoc.c b/drivers/net/wireless/ath/ath10k/snoc.c
index aa8a9b36250e..a0504b8e003c 100644
--- a/drivers/net/wireless/ath/ath10k/snoc.c
+++ b/drivers/net/wireless/ath/ath10k/snoc.c
@@ -1500,13 +1500,13 @@ static int ath10k_snoc_probe(struct platform_device *pdev)
ar_snoc->ce.bus_ops = &ath10k_snoc_bus_ops;
ar->ce_priv = &ar_snoc->ce;

- ath10k_snoc_resource_init(ar);
+ ret = ath10k_snoc_resource_init(ar);
if (ret) {
ath10k_warn(ar, "failed to initialize resource: %d\n", ret);
goto err_core_destroy;
}

- ath10k_snoc_setup_resource(ar);
+ ret = ath10k_snoc_setup_resource(ar);
if (ret) {
ath10k_warn(ar, "failed to setup resource: %d\n", ret);
goto err_core_destroy;
--
2.17.0

2018-06-14 15:21:43

by Kalle Valo

Subject: Re: ath10k: Handle resource init failure case

Govind Singh <[email protected]> wrote:

> Return type of resource init method is not assigned.
> Handle resource init failures for graceful exit.
>
> Signed-off-by: Govind Singh <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

d16a7ab20ac9 ath10k: handle resource init failure case

--
https://patchwork.kernel.org/patch/10461677/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches