2020-11-04 16:40:32

by Tamizh chelvam

Subject: [PATCH] ath10k: fix compilation warning

From: Tamizh Chelvam <[email protected]>

This change fixes below compilation warning.

smatch warnings:
drivers/net/wireless/ath/ath10k/mac.c:9125 ath10k_mac_op_set_tid_config() error: uninitialized symbol 'ret'.

No functional changes. Compile tested only.

Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Signed-off-by: Tamizh Chelvam <[email protected]>
---
drivers/net/wireless/ath/ath10k/mac.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/ath10k/mac.c b/drivers/net/wireless/ath/ath10k/mac.c
index 12edb1b..9f3224d 100644
--- a/drivers/net/wireless/ath/ath10k/mac.c
+++ b/drivers/net/wireless/ath/ath10k/mac.c
@@ -9182,10 +9182,11 @@ static int ath10k_mac_op_set_tid_config(struct ieee80211_hw *hw,
goto exit;
}

+ ret = 0;
+
if (sta)
goto exit;

- ret = 0;
arvif->tids_rst = 0;
data.curr_vif = vif;
data.ar = ar;
--
1.9.1

2020-11-07 07:58:51

by Kalle Valo

Subject: Re: [PATCH] ath10k: fix compilation warning

Tamizh chelvam <[email protected]> wrote:

> This change fixes below compilation warning.
>
> smatch warnings:
> drivers/net/wireless/ath/ath10k/mac.c:9125 ath10k_mac_op_set_tid_config() error: uninitialized symbol 'ret'.
>
> No functional changes. Compile tested only.
>
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Signed-off-by: Tamizh Chelvam <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

b91626451178 ath10k: fix compilation warning

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches