2021-01-28 07:37:37

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] ath9k: Add separate entry for LED triggers to fix module builds

Krzysztof Kozlowski <[email protected]> wrote:

> After commit 72cdab808714 ("ath9k: Do not select MAC80211_LEDS by
> default") a configuration like:
> - MAC80211_LEDS=y
> - NEW_LEDS=y
> - ATH9K=y
> leads to a build failure:
> /usr/bin/ld: drivers/net/wireless/ath/ath9k/gpio.o: in function `ath_deinit_leds':
> drivers/net/wireless/ath/ath9k/gpio.c:69: undefined reference to `led_classdev_unregister'
> /usr/bin/ld: drivers/net/wireless/ath/ath9k/gpio.o: in function `led_classdev_register':
> include/linux/leds.h:190: undefined reference to `led_classdev_register_ext'
> To be able to use LED triggers, the LEDS_CLASS can only be a module
> if ath9k driver is a module as well.
> Reported-by: kernel test robot <[email protected]>
> Fixes: 72cdab808714 ("ath9k: Do not select MAC80211_LEDS by default")
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

I took Arnd's patch instead:

https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

But I think we really need the cleanup Arnd proposes during the discussion so
that we have consistent LED handling in wireless drivers. Patches very welcome.

Patch set to Superseded.

https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/