On 2/15/21 6:05 AM, Colin King wrote:
> From: Colin Ian King <[email protected]>
>
> The documentation for the PHY update [1] states:
>
> Loop 4 times with index i
>
> If PHY Revision >= 3
> Copy table[i] to coef[i]
> Otherwise
> Set coef[i] to 0
>
> the copy of the table to coef is currently implemented the wrong way
> around, table is being updated from uninitialized values in coeff.
> Fix this by swapping the assignment around.
>
> [1] https://bcm-v4.sipsolutions.net/802.11/PHY/N/RestoreCal/
>
> Fixes: 2f258b74d13c ("b43: N-PHY: implement restoring general configuration")
> Addresses-Coverity: ("Uninitialized scalar variable")
> Signed-off-by: Colin Ian King <[email protected]>
> ---
> drivers/net/wireless/broadcom/b43/phy_n.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/b43/phy_n.c b/drivers/net/wireless/broadcom/b43/phy_n.c
> index b669dff24b6e..665b737fbb0d 100644
> --- a/drivers/net/wireless/broadcom/b43/phy_n.c
> +++ b/drivers/net/wireless/broadcom/b43/phy_n.c
> @@ -5311,7 +5311,7 @@ static void b43_nphy_restore_cal(struct b43_wldev *dev)
>
> for (i = 0; i < 4; i++) {
> if (dev->phy.rev >= 3)
> - table[i] = coef[i];
> + coef[i] = table[i];
> else
> coef[i] = 0;
> }
>
Acked-by: Larry Finger <[email protected]>
Good catch, thanks.
Larry