2021-03-09 10:10:28

by Lorenzo Bianconi

[permalink] [raw]
Subject: [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting

Fix {tx,rx}_airtime reporting for mt7921 driver. Wrong register definitions
trigger a tx hangs before resetting airtime stats.

Fixes: 163f4d22c118d ("mt76: mt7921: add MAC support")
Tested-by: Leon Yen <[email protected]>
Signed-off-by: Lorenzo Bianconi <[email protected]>
---
drivers/net/wireless/mediatek/mt76/mt7921/regs.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/regs.h b/drivers/net/wireless/mediatek/mt76/mt7921/regs.h
index 18980bb32dee..6dad7f6ab09d 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/regs.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/regs.h
@@ -135,10 +135,10 @@

#define MT_WTBLON_TOP_BASE 0x34000
#define MT_WTBLON_TOP(ofs) (MT_WTBLON_TOP_BASE + (ofs))
-#define MT_WTBLON_TOP_WDUCR MT_WTBLON_TOP(0x0)
+#define MT_WTBLON_TOP_WDUCR MT_WTBLON_TOP(0x200)
#define MT_WTBLON_TOP_WDUCR_GROUP GENMASK(2, 0)

-#define MT_WTBL_UPDATE MT_WTBLON_TOP(0x030)
+#define MT_WTBL_UPDATE MT_WTBLON_TOP(0x230)
#define MT_WTBL_UPDATE_WLAN_IDX GENMASK(9, 0)
#define MT_WTBL_UPDATE_ADM_COUNT_CLEAR BIT(12)
#define MT_WTBL_UPDATE_BUSY BIT(31)
--
2.29.2


2021-03-09 10:32:14

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting

Lorenzo Bianconi <[email protected]> writes:

> Fix {tx,rx}_airtime reporting for mt7921 driver. Wrong register definitions
> trigger a tx hangs before resetting airtime stats.
>
> Fixes: 163f4d22c118d ("mt76: mt7921: add MAC support")
> Tested-by: Leon Yen <[email protected]>
> Signed-off-by: Lorenzo Bianconi <[email protected]>

I'll queue this to v5.12 and assigned to me on patchwork. Felix, ack?

--
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

2021-03-09 12:56:24

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting



> On 9. Mar 2021, at 11:29, Kalle Valo <[email protected]> wrote:
>
> Lorenzo Bianconi <[email protected]> writes:
>
>> Fix {tx,rx}_airtime reporting for mt7921 driver. Wrong register definitions
>> trigger a tx hangs before resetting airtime stats.
>>
>> Fixes: 163f4d22c118d ("mt76: mt7921: add MAC support")
>> Tested-by: Leon Yen <[email protected]>
>> Signed-off-by: Lorenzo Bianconi <[email protected]>
>
> I'll queue this to v5.12 and assigned to me on patchwork. Felix, ack?
Acked-by: Felix Fietkau <[email protected]>

2021-03-23 09:40:10

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH wireless-drivers] mt76: mt7921: fix airtime reporting

Lorenzo Bianconi <[email protected]> wrote:

> Fix {tx,rx}_airtime reporting for mt7921 driver. Wrong register definitions
> trigger a tx hangs before resetting airtime stats.
>
> Fixes: 163f4d22c118d ("mt76: mt7921: add MAC support")
> Tested-by: Leon Yen <[email protected]>
> Signed-off-by: Lorenzo Bianconi <[email protected]>
> Acked-by: Felix Fietkau <[email protected]>

Patch applied to wireless-drivers.git, thanks.

8f6a70fd71a3 mt76: mt7921: fix airtime reporting

--
https://patchwork.kernel.org/project/linux-wireless/patch/c05333be0e3e85a50a71bb2de81034fe425e3701.1615284335.git.lorenzo@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches