2021-03-18 02:03:13

by A. Cody Schuffelen

[permalink] [raw]
Subject: [PATCH] virt_wifi: Return micros for BSS TSF values

cfg80211_inform_bss expects to receive a TSF value, but is given the
time since boot in nanoseconds. TSF values are expected to be at
microsecond scale rather than nanosecond scale.

Signed-off-by: A. Cody Schuffelen <[email protected]>
drivers/net/wireless/virt_wifi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/virt_wifi.c b/drivers/net/wireless/virt_wifi.c
index c878097f0dda..07cefd0a86be 100644
--- a/drivers/net/wireless/virt_wifi.c
+++ b/drivers/net/wireless/virt_wifi.c
@@ -172,7 +172,7 @@ static void virt_wifi_scan_result(struct work_struct *work)
informed_bss = cfg80211_inform_bss(wiphy, &channel_5ghz,
- ktime_get_boottime_ns(),
+ ktime_get_boottime_ns() / 1000,
(void *)&ssid, sizeof(ssid),

2021-03-18 13:20:41

by kernel test robot

[permalink] [raw]
Subject: Re: [PATCH] virt_wifi: Return micros for BSS TSF values

Hi Cody,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on wireless-drivers-next/master]
[also build test ERROR on wireless-drivers/master ipvs/master v5.12-rc3 next-20210317]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in

url: https://github.com/0day-ci/linux/commits/A-Cody-Schuffelen/virt_wifi-Return-micros-for-BSS-TSF-values/20210318-100417
base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git master
config: arm-allyesconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/6c3f5b51c512d7947ccef9ef5e6a1ee352b77b63
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review A-Cody-Schuffelen/virt_wifi-Return-micros-for-BSS-TSF-values/20210318-100417
git checkout 6c3f5b51c512d7947ccef9ef5e6a1ee352b77b63
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email protected]>

All errors (new ones prefixed by >>):

arm-linux-gnueabi-ld: drivers/net/wireless/virt_wifi.o: in function `virt_wifi_scan_result':
>> virt_wifi.c:(.text+0xac8): undefined reference to `__aeabi_uldivmod'

0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email protected]

(No filename) (1.78 kB)
.config.gz (76.09 kB)
Download all attachments