2021-04-07 20:42:17

by Jiapeng Chong

[permalink] [raw]
Subject: [PATCH] wil6210: wmi: Remove useless code

Fix the following whitescan warning:

An unsigned value can never be less than 0.

Reported-by: Abaci Robot <[email protected]>
Signed-off-by: Jiapeng Chong <[email protected]>
---
drivers/net/wireless/ath/wil6210/wmi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/wireless/ath/wil6210/wmi.c b/drivers/net/wireless/ath/wil6210/wmi.c
index 823ec6e..02ad449 100644
--- a/drivers/net/wireless/ath/wil6210/wmi.c
+++ b/drivers/net/wireless/ath/wil6210/wmi.c
@@ -1456,7 +1456,7 @@ static void wil_link_stats_store_basic(struct wil6210_vif *vif,
u8 cid = basic->cid;
struct wil_sta_info *sta;

- if (cid < 0 || cid >= wil->max_assoc_sta) {
+ if (cid >= wil->max_assoc_sta) {
wil_err(wil, "invalid cid %d\n", cid);
return;
}
--
1.8.3.1


2021-04-18 06:39:28

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH] wil6210: wmi: Remove useless code

Jiapeng Chong <[email protected]> wrote:

> Fix the following whitescan warning:
>
> An unsigned value can never be less than 0.
>
> Reported-by: Abaci Robot <[email protected]>
> Signed-off-by: Jiapeng Chong <[email protected]>

Patch applied to wireless-drivers-next.git, thanks.

5e6087559e85 wil6210: wmi: Remove useless code

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]m/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches