2021-05-19 18:27:06

by Kalle Valo

[permalink] [raw]
Subject: Re: [PATCH v2] b43: don't save dentries for debugfs

Greg Kroah-Hartman <[email protected]> writes:

> There is no need to keep around the dentry pointers for the debugfs
> files as they will all be automatically removed when the subdir is
> removed. So save the space and logic involved in keeping them around by
> just getting rid of them entirely.
> By doing this change, we remove one of the last in-kernel user that was
> storing the result of debugfs_create_bool(), so that api can be cleaned
> up.
> Cc: Kalle Valo <[email protected]>
> Cc: "David S. Miller" <[email protected]>
> Cc: Jakub Kicinski <[email protected]>
> Cc: Kees Cook <[email protected]>
> Cc: Greg Kroah-Hartman <[email protected]>
> Cc: Jason Gunthorpe <[email protected]>
> Cc: Chao Yu <[email protected]>
> Cc: Leon Romanovsky <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Cc: [email protected]
> Signed-off-by: Greg Kroah-Hartman <[email protected]>
> ---
> drivers/net/wireless/broadcom/b43/debugfs.c | 34 +++------------------
> drivers/net/wireless/broadcom/b43/debugfs.h | 3 --
> 2 files changed, 5 insertions(+), 32 deletions(-)
> Note, I can take this through my debugfs tree if wanted, that way I can
> clean up the debugfs_create_bool() api at the same time. Otherwise it's
> fine, I can wait until next -rc1 for that to happen.

Yeah, it's best that you take this via your tree.

Acked-by: Kalle Valo <[email protected]>