2021-06-21 14:16:00

by MeiChia Chiu

[permalink] [raw]
Subject: [PATCH] mt76: mt7915: add LED support

From: MeiChia Chiu <[email protected]>

Initialize brightness_set and blink_set callbacks to enable LED support.

Signed-off-by: MeiChia Chiu <[email protected]>
Signed-off-by: Ryder Lee <[email protected]>
Signed-off-by: Money Wang <[email protected]>
---
.../net/wireless/mediatek/mt76/mt7915/init.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
.../net/wireless/mediatek/mt76/mt7915/mmio.c | 6 +++--
.../net/wireless/mediatek/mt76/mt7915/regs.h | 19 ++++++++++++++
3 files changed, 92 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
index e027273..defb0ec 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
@@ -151,6 +151,64 @@ static int mt7915_thermal_init(struct mt7915_phy *phy)
return 0;
}

+static void mt7915_led_set_config(struct led_classdev *led_cdev,
+ u8 delay_on, u8 delay_off)
+{
+ struct mt7915_dev *dev;
+ struct mt76_dev *mt76;
+ u32 val;
+
+ mt76 = container_of(led_cdev, struct mt76_dev, led_cdev);
+ dev = container_of(mt76, struct mt7915_dev, mt76);
+
+ /* select TX blink mode, 2: only data frames */
+ mt76_rmw_field(dev, MT_TMAC_TCR0(0), MT_TMAC_TCR0_TX_BLINK, 2);
+
+ /* enable LED */
+ mt76_wr(dev, MT_LED_EN(0), 1);
+
+ /* set LED Tx blink on/off time */
+ val = FIELD_PREP(MT_LED_TX_BLINK_ON_MASK, delay_on) |
+ FIELD_PREP(MT_LED_TX_BLINK_OFF_MASK, delay_off);
+ mt76_wr(dev, MT_LED_TX_BLINK(0), val);
+
+ /* control LED */
+ val = MT_LED_CTRL_BLINK_MODE | MT_LED_CTRL_KICK;
+ if (dev->mt76.led_al)
+ val |= MT_LED_CTRL_POLARITY;
+
+ mt76_wr(dev, MT_LED_CTRL(0), val);
+ mt76_clear(dev, MT_LED_CTRL(0), MT_LED_CTRL_KICK);
+}
+
+static int mt7915_led_set_blink(struct led_classdev *led_cdev,
+ unsigned long *delay_on,
+ unsigned long *delay_off)
+{
+ u16 delta_on, delta_off;
+
+#define HW_TICK 10
+#define TO_HW_TICK(_t) (((_t) > HW_TICK) ? ((_t) / HW_TICK) : HW_TICK)
+
+ if (*delay_on)
+ delta_on = TO_HW_TICK(*delay_on);
+ if (*delay_off)
+ delta_off = TO_HW_TICK(*delay_off);
+
+ mt7915_led_set_config(led_cdev, delta_on, delta_off);
+
+ return 0;
+}
+
+static void mt7915_led_set_brightness(struct led_classdev *led_cdev,
+ enum led_brightness brightness)
+{
+ if (!brightness)
+ mt7915_led_set_config(led_cdev, 0, 0xff);
+ else
+ mt7915_led_set_config(led_cdev, 0xff, 0);
+}
+
static void
mt7915_init_txpower(struct mt7915_dev *dev,
struct ieee80211_supported_band *sband)
@@ -308,6 +366,11 @@ static void mt7915_mac_init(struct mt7915_dev *dev)
MT_WTBL_UPDATE_ADM_COUNT_CLEAR);
for (i = 0; i < 2; i++)
mt7915_mac_init_band(dev, i);
+
+ if (IS_ENABLED(CONFIG_MT76_LEDS)) {
+ i = dev->mt76.led_pin ? MT_LED_GPIO_MUX3 : MT_LED_GPIO_MUX2;
+ mt76_rmw_field(dev, i, MT_LED_GPIO_SEL_MASK, 4);
+ }
}

static int mt7915_txbf_init(struct mt7915_dev *dev)
@@ -822,6 +885,12 @@ int mt7915_register_device(struct mt7915_dev *dev)
dev->mt76.test_ops = &mt7915_testmode_ops;
#endif

+ /* init led callbacks */
+ if (IS_ENABLED(CONFIG_MT76_LEDS)) {
+ dev->mt76.led_cdev.brightness_set = mt7915_led_set_brightness;
+ dev->mt76.led_cdev.blink_set = mt7915_led_set_blink;
+ }
+
ret = mt76_register_device(&dev->mt76, true, mt76_rates,
ARRAY_SIZE(mt76_rates));
if (ret)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c b/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c
index af712a9..43f9245 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c
@@ -92,10 +92,12 @@ static u32 __mt7915_reg_addr(struct mt7915_dev *dev, u32 addr)
}

if ((addr >= 0x18000000 && addr < 0x18c00000) ||
- (addr >= 0x70000000 && addr < 0x78000000) ||
- (addr >= 0x7c000000 && addr < 0x7c400000))
+ (addr >= 0x70000000 && addr < 0x78000000))
return mt7915_reg_map_l1(dev, addr);

+ if (addr >= 0x7c000000 && addr < 0x7c400000)
+ return mt7915_reg_map_l1(dev, addr - 0x64000000);
+
return mt7915_reg_map_l2(dev, addr);
}

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/regs.h b/drivers/net/wireless/mediatek/mt76/mt7915/regs.h
index ff31b3d..b1df0bb 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7915/regs.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/regs.h
@@ -57,6 +57,7 @@
#define MT_WF_TMAC(_band, ofs) (MT_WF_TMAC_BASE(_band) + (ofs))

#define MT_TMAC_TCR0(_band) MT_WF_TMAC(_band, 0)
+#define MT_TMAC_TCR0_TX_BLINK GENMASK(7, 6)
#define MT_TMAC_TCR0_TBTT_STOP_CTRL BIT(25)

#define MT_TMAC_CDTR(_band) MT_WF_TMAC(_band, 0x090)
@@ -426,6 +427,10 @@
#define MT_TOP_MISC MT_TOP(0xf0)
#define MT_TOP_MISC_FW_STATE GENMASK(2, 0)

+#define MT_LED_GPIO_MUX2 0x70005058 /* GPIO 18 */
+#define MT_LED_GPIO_MUX3 0x7000505C /* GPIO 26 */
+#define MT_LED_GPIO_SEL_MASK GENMASK(11, 8)
+
#define MT_HW_BOUND 0x70010020
#define MT_HW_CHIPID 0x70010200
#define MT_HW_REV 0x70010204
@@ -438,6 +443,20 @@
#define MT_PCIE_MAC(ofs) (MT_PCIE_MAC_BASE + (ofs))
#define MT_PCIE_MAC_INT_ENABLE MT_PCIE_MAC(0x188)

+#define MT_LED_TOP_BASE 0x7c013000
+#define MT_LED_PHYS(_n) (MT_LED_TOP_BASE + (_n))
+
+#define MT_LED_CTRL(_n) MT_LED_PHYS(0x00 + ((_n) * 4))
+#define MT_LED_CTRL_KICK BIT(7)
+#define MT_LED_CTRL_BLINK_MODE BIT(2)
+#define MT_LED_CTRL_POLARITY BIT(1)
+
+#define MT_LED_TX_BLINK(_n) MT_LED_PHYS(0x10 + ((_n) * 4))
+#define MT_LED_TX_BLINK_ON_MASK GENMASK(7, 0)
+#define MT_LED_TX_BLINK_OFF_MASK GENMASK(15, 8)
+
+#define MT_LED_EN(_n) MT_LED_PHYS(0x40 + ((_n) * 4))
+
#define MT_WF_IRPI_BASE 0x83006000
#define MT_WF_IRPI(ofs) (MT_WF_IRPI_BASE + ((ofs) << 16))

--
2.29.2


2021-08-13 11:50:30

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7915: add LED support


On 2021-06-21 16:14, MeiChia Chiu wrote:
> From: MeiChia Chiu <[email protected]>
>
> Initialize brightness_set and blink_set callbacks to enable LED support.
>
> Signed-off-by: MeiChia Chiu <[email protected]>
> Signed-off-by: Ryder Lee <[email protected]>
> Signed-off-by: Money Wang <[email protected]>
> ---
> .../net/wireless/mediatek/mt76/mt7915/init.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
> .../net/wireless/mediatek/mt76/mt7915/mmio.c | 6 +++--
> .../net/wireless/mediatek/mt76/mt7915/regs.h | 19 ++++++++++++++
> 3 files changed, 92 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> index e027273..defb0ec 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> @@ -151,6 +151,64 @@ static int mt7915_thermal_init(struct mt7915_phy *phy)
> return 0;
> }
>
> +static void mt7915_led_set_config(struct led_classdev *led_cdev,
> + u8 delay_on, u8 delay_off)
> +{
> + struct mt7915_dev *dev;
> + struct mt76_dev *mt76;
> + u32 val;
> +
> + mt76 = container_of(led_cdev, struct mt76_dev, led_cdev);
> + dev = container_of(mt76, struct mt7915_dev, mt76);
> +
> + /* select TX blink mode, 2: only data frames */
> + mt76_rmw_field(dev, MT_TMAC_TCR0(0), MT_TMAC_TCR0_TX_BLINK, 2);
Does that mean the hw triggers the LED with the configured on/off delay
on TX? I think blinking should be controlled entirely by software.

- Felix

2021-08-13 16:11:39

by Ryder Lee

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7915: add LED support

On Fri, 2021-08-13 at 12:52 +0200, Felix Fietkau wrote:
> On 2021-06-21 16:14, MeiChia Chiu wrote:
> > From: MeiChia Chiu <mei[email protected]>
> >
> > Initialize brightness_set and blink_set callbacks to enable LED
> > support.
> >
> > Signed-off-by: MeiChia Chiu <[email protected]>
> > Signed-off-by: Ryder Lee <[email protected]>
> > Signed-off-by: Money Wang <[email protected]>
> > ---
> > .../net/wireless/mediatek/mt76/mt7915/init.c | 69
> > +++++++++++++++++++++++++++++++++++++++++++++++++++
> > .../net/wireless/mediatek/mt76/mt7915/mmio.c | 6 +++--
> > .../net/wireless/mediatek/mt76/mt7915/regs.h | 19 ++++++++++++++
> > 3 files changed, 92 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> > b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> > index e027273..defb0ec 100644
> > --- a/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> > +++ b/drivers/net/wireless/mediatek/mt76/mt7915/init.c
> > @@ -151,6 +151,64 @@ static int mt7915_thermal_init(struct
> > mt7915_phy *phy)
> > return 0;
> > }
> >
> > +static void mt7915_led_set_config(struct led_classdev *led_cdev,
> > + u8 delay_on, u8 delay_off)
> > +{
> > + struct mt7915_dev *dev;
> > + struct mt76_dev *mt76;
> > + u32 val;
> > +
> > + mt76 = container_of(led_cdev, struct mt76_dev, led_cdev);
> > + dev = container_of(mt76, struct mt7915_dev, mt76);
> > +
> > + /* select TX blink mode, 2: only data frames */
> > + mt76_rmw_field(dev, MT_TMAC_TCR0(0), MT_TMAC_TCR0_TX_BLINK, 2);
>
> Does that mean the hw triggers the LED with the configured on/off
> delay
> on TX? I think blinking should be controlled entirely by software.
>

Blink is still contolled by software. This means upper layer can set
on/off directly.


Ryder

2021-08-27 17:04:48

by Felix Fietkau

[permalink] [raw]
Subject: Re: [PATCH] mt76: mt7915: add LED support


On 2021-06-21 16:14, MeiChia Chiu wrote:
> From: MeiChia Chiu <[email protected]>
>
> Initialize brightness_set and blink_set callbacks to enable LED support.
>
> Signed-off-by: MeiChia Chiu <[email protected]>
> Signed-off-by: Ryder Lee <[email protected]>
> Signed-off-by: Money Wang <[email protected]>
> ---
> .../net/wireless/mediatek/mt76/mt7915/init.c | 69 +++++++++++++++++++++++++++++++++++++++++++++++++++
> .../net/wireless/mediatek/mt76/mt7915/mmio.c | 6 +++--
> .../net/wireless/mediatek/mt76/mt7915/regs.h | 19 ++++++++++++++
> 3 files changed, 92 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c b/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c
> index af712a9..43f9245 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7915/mmio.c
> @@ -92,10 +92,12 @@ static u32 __mt7915_reg_addr(struct mt7915_dev *dev, u32 addr)
> }
>
> if ((addr >= 0x18000000 && addr < 0x18c00000) ||
> - (addr >= 0x70000000 && addr < 0x78000000) ||
> - (addr >= 0x7c000000 && addr < 0x7c400000))
> + (addr >= 0x70000000 && addr < 0x78000000))
> return mt7915_reg_map_l1(dev, addr);
>
> + if (addr >= 0x7c000000 && addr < 0x7c400000)
> + return mt7915_reg_map_l1(dev, addr - 0x64000000);

This part doesn't make any sense to me. So you're defining registers in
the 0x7c000000 range, but subtracting 0x64000000 from the address, which
means we land at 0x18000000, which is already covered by the l1-mapped
ranges.
Why not just skip this weird magic trick and define the registers as
being in the 0x18000000 range?

- Felix